Add "Forgot Password" Functionality #460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Winston-Hsiao
requested changes
Oct 11, 2024
|
I have added the Please review the changes and let me know if any modifications or improvements are needed. |
|
Hey @gaurav-jo1 sorry we've been busy shipping some larger features. There's some merge conflicts but we'd love to get your forgot password functionality you made merged in. Sorry for the delay! |
|
Hey Winston, no worries at all! I'd love to help get that merged. Since the UI has changed quite a bit recently, I'll need to update the UI in my PR as well. Give me a little time, and I'll get that sorted! |
gaurav-jo1
force-pushed
the
forgot_pass
branch
from
9672dd6
to
655e4a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the "Forgot Password" functionality to enhance user experience and security.
What issues does this PR fix or reference?
#411
If this PR changes the UI, include a screenshot below.
k_scale_labs.mp4
Additional Notes:
The
/forgot-passwordendpoint response does not disclose whether the email exists in the system, preventing potential enumeration attacks.Added the
remove_existing_token_for_emailfunction to ensure that if a user makes multiple reset password requests, any previous tokens are invalidated.Please let me know if there are any changes you’d like to make.