Generate Recommendations with MetricProfile queries #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4a2a30e.
shreyabiradar07
added
local_monitoring
kruize-local
| } | ||
|
|
||
| promQL = promQL | ||
| .replace(AnalyzerConstants.NAMESPACE_VARIABLE, namespace) |
There was a problem hiding this comment.
Add some more replace like workload type , name etc
please refer to kusuma's latest PR's quires
| * @param dataSourceInfo | ||
| * @throws Exception | ||
| */ | ||
| public void fetchMetricsBasedOnProfileAndDatasource(KruizeObject kruizeObject, Timestamp interval_end_time, Timestamp interval_start_time, DataSourceInfo dataSourceInfo) throws Exception { |
There was a problem hiding this comment.
1 Transfer DSMetadata queries to the metric profile.
-
Relocate Container last active date queries to the metric
profile and update the code to reference queries using the metric profile. -
Adjust requests and limit queries to avoid using query_range.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has the following changes:
MetricProfilewithlocal_monitoringexperimentsMetricProfileinstead of constant valuesType of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
.