-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Recommendations with MetricProfile queries #1237
Generate Recommendations with MetricProfile queries #1237
Conversation
This reverts commit 4a2a30e.
} | ||
|
||
promQL = promQL | ||
.replace(AnalyzerConstants.NAMESPACE_VARIABLE, namespace) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some more replace like workload type , name etc
please refer to kusuma's latest PR's quires
* @param dataSourceInfo | ||
* @throws Exception | ||
*/ | ||
public void fetchMetricsBasedOnProfileAndDatasource(KruizeObject kruizeObject, Timestamp interval_end_time, Timestamp interval_start_time, DataSourceInfo dataSourceInfo) throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Transfer DSMetadata queries to the metric profile.
-
Relocate Container last active date queries to the metric
profile and update the code to reference queries using the metric profile. -
Adjust requests and limit queries to avoid using query_range.
Description
This PR has the following changes:
MetricProfile
withlocal_monitoring
experimentsMetricProfile
instead of constant valuesType of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
.