Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List metric profiles with name and verbose query parameters #1240

Merged

Conversation

shreyabiradar07
Copy link
Contributor

Description

This PR extends /listMetricProfiles API supporting name and verbose query parameters

NOTE - this PR is created on top of PR 1237, has a dependency to be merged first

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: minikube

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Image - quay.io/shbirada/list_metric_profile:api

@shreyabiradar07 shreyabiradar07 self-assigned this Jul 24, 2024
@shreyabiradar07 shreyabiradar07 added the kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase label Jul 24, 2024
@msvinaykumar
Copy link
Contributor

Will review once base PR are merged
Below listed PRs are from the hackathon development, #1224 being the base PR
Support in-memory storage of MetricProfile - #1235
Generate Recommendations with MetricProfile queries- #1237
List metric profiles with name and verbose query parameters - #1240

@chandrams
Copy link
Contributor

@msvinaykumar I have merged #1224 & #1235

@chandrams chandrams merged commit 06f3968 into kruize:202407-hackathon Jul 30, 2024
2 of 3 checks passed
@shreyabiradar07 shreyabiradar07 removed this from the Kruize 0.0.24_rm Release milestone Aug 21, 2024
@shreyabiradar07 shreyabiradar07 added this to the Hackathon branch milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kruize-local Tag for mentioning all the PR's and issues raised which covers the kruize local monitoring usecase remote_monitoring
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants