add mkinitcpio hook for Arch and sample /etc/mkinitcpio.conf #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibrokemypie
reviewed
Dec 19, 2019
| #!/bin/bash | ||
|
|
||
| build() { | ||
| add_module `bcachefs` |
There was a problem hiding this comment.
the backticks here rather than quotes causes mkinitcpio to spit out ==> ERROR: module not found: `bcachefs:'
switching them to quotation marks makes mkinitcpio run fine
There was a problem hiding this comment.
or no quotes at all, as is done in existing hooks. Same for add_binary below.
koverstreet
force-pushed
the
master
branch
2 times, most recently
from
d31cdf9
to
8a632ea
Compare
koverstreet
force-pushed
the
master
branch
2 times, most recently
from
8d71b04
to
c8bec83
Compare
koverstreet
force-pushed
the
master
branch
2 times, most recently
from
f6c80f9
to
138397d
Compare
mmmspatz
reviewed
May 26, 2024
| run_hook() { | ||
|
|
||
| # check if $root needs unlocking | ||
| if bcachefs unlock -c $root >/dev/null 2>&1; then |
There was a problem hiding this comment.
This fails if root isn't a dev path (eg. UUID=), because only bcahcefs mount knows how to handle that.
Could do what some existing hooks do (resume)
local rootdev
if rootdev="$(resolve_device "$root")" && \
bcachefs unlock -c "$rootdev" >/dev/null 2>&1; then
echo "Unlocking $rootdev:"
while true; do
bcachefs unlock "$rootdev" && break
done
fi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the necessary initcpio hook for Arch to boot from an encrypted root bcachefs drive/partition. For the time being, the hook is kept in the custom hooks directory (
/etc/initcpio/hooks) as per the Arch wiki. As things get mainlined and become part of the kernel, we may want to move the hook into the system hooks directory (/usr/lib/initcpio/hooks). There is an example of a working/etc/mkinitcpio.confthat calls the bcachefs hook when creating a new initramfs withmkinitcpio -p linux-bcachefs.