Skip to content

Commit

Permalink
New setattr command
Browse files Browse the repository at this point in the history
  • Loading branch information
koverstreet committed Dec 19, 2018
1 parent e45b8ac commit 94cafcb
Show file tree
Hide file tree
Showing 3 changed files with 120 additions and 0 deletions.
5 changes: 5 additions & 0 deletions bcachefs.c
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ static void usage(void)
" migrate Migrate an existing filesystem to bcachefs, in place\n"
" migrate-superblock Add default superblock, after bcachefs migrate\n"
"\n"
"Commands for operating on files in a bcachefs filesystem:\n"
" setattr Set various per file attributes\n"
"Debug:\n"
"These commands work on offline, unmounted filesystems\n"
" dump Dump filesystem metadata to a qcow2 image\n"
Expand Down Expand Up @@ -198,6 +200,9 @@ int main(int argc, char *argv[])
if (!strcmp(cmd, "list"))
return cmd_list(argc, argv);

if (!strcmp(cmd, "setattr"))
return cmd_setattr(argc, argv);

if (!strcmp(cmd, "--help")) {
usage();
return 0;
Expand Down
113 changes: 113 additions & 0 deletions cmd_attr.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,113 @@
#include <dirent.h>
#include <stdio.h>
#include <sys/ioctl.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/xattr.h>
#include <unistd.h>

#include "libbcachefs/bcachefs_ioctl.h"

#include "cmds.h"
#include "libbcachefs.h"

static void propagate_recurse(int dirfd)
{
DIR *dir = fdopendir(dirfd);
struct dirent *d;

while ((errno = 0), (d = readdir(dir))) {
if (!strcmp(d->d_name, ".") ||
!strcmp(d->d_name, ".."))
continue;

int ret = ioctl(dirfd, BCHFS_IOC_REINHERIT_ATTRS,
d->d_name);
if (ret < 0) {
fprintf(stderr, "error propagating attributes to %s: %m\n",
d->d_name);
continue;
}

if (!ret) /* did no work */
continue;

struct stat st = xfstatat(dirfd, d->d_name,
AT_SYMLINK_NOFOLLOW);
if (!S_ISDIR(st.st_mode))
continue;

int fd = openat(dirfd, d->d_name, O_RDONLY);
if (fd < 0) {
fprintf(stderr, "error opening %s: %m\n", d->d_name);
continue;
}
propagate_recurse(fd);
close(fd);
}

if (errno)
die("readdir error: %m");
}

static void do_setattr(char *path, struct bch_opt_strs opts)
{
unsigned i;

for (i = 0; i < bch2_opts_nr; i++) {
if (!opts.by_id[i])
continue;

char *n = mprintf("bcachefs.%s", bch2_opt_table[i].attr.name);

if (setxattr(path, n, opts.by_id[i], strlen(opts.by_id[i]), 0))
die("setxattr error: %m");

free(n);
}

struct stat st = xstat(path);
if (!S_ISDIR(st.st_mode))
return;

int dirfd = open(path, O_RDONLY);
if (dirfd < 0)
die("error opening %s: %m", path);

propagate_recurse(dirfd);
close(dirfd);
}

static void setattr_usage(void)
{
puts("bcachefs setattr - set attributes on files in a bcachefs filessytem\n"
"Usage: bcachefs setattr [OPTIONS]... <files>\n"
"\n"
"Options:");

bch2_opts_usage(OPT_INODE);
puts(" -h Display this help and exit\n"
"Report bugs to <[email protected]>");
}

int cmd_setattr(int argc, char *argv[])
{
struct bch_opt_strs opts =
bch2_cmdline_opts_get(&argc, argv, OPT_INODE);
unsigned i;

for (i = 1; i < argc; i++)
if (argv[i][0] == '-') {
printf("invalid option %s\n", argv[i]);
setattr_usage();
exit(EXIT_FAILURE);
}

if (argc <= 1)
die("Please supply one or more files");

for (i = 1; i < argc; i++)
do_setattr(argv[i], opts);

return 0;
}
2 changes: 2 additions & 0 deletions cmds.h
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,6 @@ int cmd_migrate_superblock(int argc, char *argv[]);

int cmd_version(int argc, char *argv[]);

int cmd_setattr(int argc, char *argv[]);

#endif /* _CMDS_H */

0 comments on commit 94cafcb

Please sign in to comment.