Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variety changes #315

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Variety changes #315

merged 6 commits into from
Jul 20, 2024

Commits on Jul 20, 2024

  1. chore: rm leftover gitignore entries 

    Signed-off-by: Thomas Mühlbacher <[email protected]>
    @tmuehlbacher
    tmuehlbacher committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    ceb5e80 View commit details
    Browse the repository at this point in the history

  2. build: rm package.version from Cargo.toml 

    This sets the version, that can be read at build time using the
environment variable `CARGO_PKG_VERSION`, to the default
value (`0.0.0`).

Setting `package.version` in the Cargo manifest is mandatory for
publishing to crates.io. We're not publishing the crate currently, and
there isn't an obvious case for doing so in the future that comes to
mind.

Our sources are not using the version from cargo currently. `clap` and
some other dependencies may use them by default but still we don't use
that version in any outputs. Therefore, we should be fine without it.

Signed-off-by: Thomas Mühlbacher <[email protected]>
    @tmuehlbacher
    tmuehlbacher committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    48c5102 View commit details
    Browse the repository at this point in the history

  3. feat(logging): switch to custom file:line format 

    This mostly tries to be similar to the default `env_logger` format but
instead of using the more vague target in the log message, we instead
put the file name and line number in the log.

Signed-off-by: Thomas Mühlbacher <[email protected]>
    @tmuehlbacher
    tmuehlbacher committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    09cde48 View commit details
    Browse the repository at this point in the history

  4. fix(logging): re-enable warn and error by default 

    Same as it was in most previous releases. Without this, you may not see
any output for certain errors.

Signed-off-by: Thomas Mühlbacher <[email protected]>
    @tmuehlbacher
    tmuehlbacher committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    e218119 View commit details
    Browse the repository at this point in the history

  5. style: nix fmt 

    Signed-off-by: Thomas Mühlbacher <[email protected]>
    @tmuehlbacher
    tmuehlbacher committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    7c68f27 View commit details
    Browse the repository at this point in the history

  6. refactor: fix clippy lint 

    Signed-off-by: Thomas Mühlbacher <[email protected]>
    @tmuehlbacher
    tmuehlbacher committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    cdcc241 View commit details
    Browse the repository at this point in the history