Variety changes #315
Merged
Variety changes #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Mühlbacher <[email protected]>
This sets the version, that can be read at build time using the environment variable `CARGO_PKG_VERSION`, to the default value (`0.0.0`). Setting `package.version` in the Cargo manifest is mandatory for publishing to crates.io. We're not publishing the crate currently, and there isn't an obvious case for doing so in the future that comes to mind. Our sources are not using the version from cargo currently. `clap` and some other dependencies may use them by default but still we don't use that version in any outputs. Therefore, we should be fine without it. Signed-off-by: Thomas Mühlbacher <[email protected]>
This mostly tries to be similar to the default `env_logger` format but instead of using the more vague target in the log message, we instead put the file name and line number in the log. Signed-off-by: Thomas Mühlbacher <[email protected]>
Same as it was in most previous releases. Without this, you may not see any output for certain errors. Signed-off-by: Thomas Mühlbacher <[email protected]>
Signed-off-by: Thomas Mühlbacher <[email protected]>
Signed-off-by: Thomas Mühlbacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.