Skip to content
This repository has been archived by the owner on Oct 18, 2020. It is now read-only.

Hopefully numbers in domains are left alone (fix issue#62) #63

Merged
merged 3 commits into from
Oct 7, 2014

Conversation

jonnybarnes
Copy link
Collaborator

Can someone double check the regex here. I was just messing around on regex101.com getting this to work.

@konklone
Copy link
Owner

konklone commented Oct 7, 2014

Could you give me a domain that's having problems? I didn't see one mentioned in #62 either.

To accept this, we need a new test in test/shaaaaa.js, using a real-world domain, that would fail under what's in the master branch right now, but which passes in this PR's branch.

@jonnybarnes
Copy link
Collaborator Author

The domain in question, the site still being under development, is teacup.p3k.io. The original regex removed the three meaning shaaaa was running the command openssl s_client -connect teacup.p3k.io:443 -servername teacup.pk.io -showcerts. Seeing as the server doesn't have a vhost for teacup.pk.io it was falling back to giving us a default cert for an unrelated domain it also hosted.

@konklone
Copy link
Owner

konklone commented Oct 7, 2014

Got it. I just verified what you were seeing, and added a test in 35d8183 for teacup.p3k.io, that fails on master and works in this PR.

We had an existing test with a domain with a number in it, individual8.com, but that domain wasn't using SNI and so the -servername flag wasn't relevant to the server's response.

Thanks for catching this! Deploying it now.

konklone added a commit that referenced this pull request Oct 7, 2014
Hopefully numbers in domains are left alone (fix issue#62)
@konklone konklone merged commit 900e701 into master Oct 7, 2014
@konklone konklone deleted the issue-62 branch October 7, 2014 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants