Merge pull request #63 from konklone/issue-62

Hopefully numbers in domains are left alone (fix issue#62)
konklone · Oct 7, 2014 · 900e701 · 900e701
2 parents cc98bf7 + 35d8183
commit 900e701
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/shaaaaa.js b/shaaaaa.js
@@ -75,7 +75,7 @@ var Shaaa = {
     if (!options) options = {};
 
     // This accounts for -servername/SNI, which cannot have a port
-    var server_name = domain.replace(/[^\w\.\-]|[$:\d+]/g, '');
+    var server_name = domain.replace(/[^\w\.\-]+(:\d+])/, '');
 
     // This accounts for -connect, which can have a port
     var server_connect = domain.replace(/[^\w\.\-:]/g, '');

diff --git a/test/shaaaaa.js b/test/shaaaaa.js
@@ -86,6 +86,16 @@ var sites = [
       {good: false, algorithm: "sha1"}
     ]
   },
+  {
+    name: "Domain with number and SNI, teacup.p3k.io",
+    domain: "teacup.p3k.io",
+
+    diagnosis: "good",
+    cert: {good: true, algorithm: "sha256"},
+    intermediates: [
+      {good: true, algorithm: "sha256"}
+    ]
+  },
   {
     name: "Domain with port, google.com:443",
     domain: "google.com:443",