refa: MessageEncoder related changes
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilharp
requested changes
Feb 20, 2024
There was a problem hiding this comment.
不要用 this.channelId.startsWith('private:') 或 this.session.isDirect
- 前者是创建 Session 时才应该使用的方法，在 Session 外部可以调用 Session 的封装来判断
- 后者已被 Satori 协议标准的
session.event.channel.type替代，session.event.channel.type会在 Satori 协议中传输而isDirect不会
session.event.channel.type 目前没有在创建 Session 时填充，需要在 prepare() 方法中做五件事来填充，可以看这里：
直接在当前类里新写 async prepare() {} 即可，Satori 会自动调用
写完以后记得本地测试一下
lgc2333
changed the title
MessageEncoder related changes
ilharp
approved these changes
Feb 21, 2024
XxLittleCxX
requested changes
Feb 21, 2024
src/bot/message.ts
Outdated
| ? Universal.Channel.Type.DIRECT | ||
| : Universal.Channel.Type.TEXT | ||
| } | ||
| this.session.isDirect = channel.type === Universal.Channel.Type.DIRECT |
There was a problem hiding this comment.
这个要设吗，core 里面的 isDirect 的 setter 和这个作用一样吧
There was a problem hiding this comment.
这个要设吗，core 里面的 isDirect 的 setter 和这个作用一样吧
在哪里
There was a problem hiding this comment.
There was a problem hiding this comment.
isDirect 是 accessor，已经设置了 type 的情况下不应该手动设置。
应当仅同步 type 本身。
| session.messageId = this.guildId | ||
| ? '' + await this.bot.internal.sendGroupForwardMsg(this.guildId, this.stack[0].children) | ||
| : '' + await this.bot.internal.sendPrivateForwardMsg(this.channelId.slice(8), this.stack[0].children) | ||
| session.messageId = this.session.event.channel.type === Universal.Channel.Type.DIRECT |
ilharp
approved these changes
Feb 24, 2024
shigma
requested changes
Feb 24, 2024
shigma
approved these changes
Feb 24, 2024
shigma
changed the title
MessageEncoder related changesMessageEncoder related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18