fix: group message sendability when using plugin server-satori
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgc2333
changed the title
channelIdchannelId
shigma
approved these changes
Feb 19, 2024
ilharp
requested changes
Feb 19, 2024
There was a problem hiding this comment.
不要用 this.channelId.startsWith('private:') 或 this.session.isDirect
- 前者是创建 Session 时才应该使用的方法，在 Session 外部可以调用 Session 的封装来判断
- 后者已被 Satori 协议标准的
session.channel.type替代，session.channel.type会在 Satori 协议中传输而isDirect不会
可能还需要 import { Channel } from 'koishi'，Apply Suggestion 以后在本地测试一下吧
| session.messageId = this.guildId | ||
| ? '' + await this.bot.internal.sendGroupForwardMsg(this.guildId, this.stack[0].children) | ||
| : '' + await this.bot.internal.sendPrivateForwardMsg(this.channelId.slice(8), this.stack[0].children) | ||
| session.messageId = this.channelId.startsWith('private:') |
There was a problem hiding this comment.
Suggested change
| session.messageId = this.channelId.startsWith('private:') | |
| session.messageId = this.session.channel.type === Channel.Type.DIRECT |
There was a problem hiding this comment.
你点进去左面的 this.session.channel.type 看下是什么类型，用相同的类型就行
There was a problem hiding this comment.
类型“Observed”上不存在属性“type”。
There was a problem hiding this comment.
确实可能是 Koishi 的版本低了，尝试升级下你的 Koishi 版本（也可以新开一个开发环境
There was a problem hiding this comment.
我的Koishi版本是4.17.0-beta.3
| : this.guildId | ||
| ? '' + await this.bot.internal.sendGroupMsg(this.guildId, this.children) | ||
| : '' + await this.bot.internal.sendPrivateMsg(this.channelId.slice(8), this.children) | ||
| : this.channelId.startsWith('private:') |
There was a problem hiding this comment.
Suggested change
| : this.channelId.startsWith('private:') | |
| : this.session.channel.type === Channel.Type.DIRECT |
lgc2333
changed the title
channelIdserver-satori
|
close due to #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.