Skip to content

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #16141

…e condition

setting the annotation before creating the PA eliminating the race condition
@knative-prow knative-prow bot requested review from dprotaso and skonto October 22, 2025 12:39
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.86%. Comparing base (9abfc28) to head (706ba71).
⚠️ Report is 1 commits behind head on release-1.18.

Files with missing lines Patch % Lines
pkg/reconciler/revision/cruds.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.18   #16190      +/-   ##
================================================
- Coverage         80.87%   80.86%   -0.01%     
================================================
  Files               210      210              
  Lines             16760    16771      +11     
================================================
+ Hits              13554    13562       +8     
- Misses             2857     2859       +2     
- Partials            349      350       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 22, 2025
@dprotaso
Copy link
Member

/retest

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2025
@knative-prow knative-prow bot merged commit 59c3292 into knative:release-1.18 Oct 23, 2025
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants