Fix: PodAutoscaler not reconciled due to missing class annotation #16141
Conversation
…e condition setting the annotation before creating the PA eliminating the race condition
knative-prow
bot
added
the
size/S
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16141 +/- ##
==========================================
- Coverage 80.08% 80.08% -0.01%
==========================================
Files 214 214
Lines 16932 16943 +11
==========================================
+ Hits 13560 13568 +8
- Misses 3014 3016 +2
- Partials 358 359 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ah this makes more sense - without the annotation (from default) the PA wouldn't be reconciled. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, nader-ziada The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/hold for a quick change |
knative-prow
bot
added
the
do-not-merge/hold
pkg/reconciler/revision/cruds.go
Outdated
| if pa.Annotations == nil { | ||
| pa.Annotations = make(map[string]string) | ||
| } | ||
| if _, ok := pa.Annotations["autoscaling.knative.dev/class"]; !ok && cfg.Autoscaler.PodAutoscalerClass != "" { |
There was a problem hiding this comment.
I'm assuming we have a constant somewhere for autoscaling.knative.dev/class
There was a problem hiding this comment.
good catch, sorry I missed that originally, updated.
|
/hold cancel |
knative-prow
bot
added
lgtm
…ative#16141) * Fix: PodAutoscaler not reconciled due to missing class annotation race condition setting the annotation before creating the PA eliminating the race condition * use constant for autoscaling.knative.dev/class
…ative#16141) (#1609) * Fix: PodAutoscaler not reconciled due to missing class annotation race condition setting the annotation before creating the PA eliminating the race condition * use constant for autoscaling.knative.dev/class
|
/cherry-pick release-1.19 |
|
@nader-ziada: new pull request created: #16190 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@nader-ziada: new pull request created: #16191 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
Fixes #16036
Proposed Changes