-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: HOME with different permissions #2361
Conversation
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
==========================================
+ Coverage 61.54% 67.10% +5.55%
==========================================
Files 129 129
Lines 15334 11931 -3403
==========================================
- Hits 9437 8006 -1431
+ Misses 4971 2962 -2009
- Partials 926 963 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/rerun all |
/test all |
/retest-required |
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for potential squelching of the permission error
The main unit test is failing because "knative" user (GH actions/ something similar) has greater permissions, I suspect. Will have to update the new test. |
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: gauron99 <[email protected]>
Signed-off-by: David Fridrich <[email protected]>
Signed-off-by: David Fridrich <[email protected]>
20d2f64
to
6f37e0c
Compare
Signed-off-by: David Fridrich <[email protected]>
@lkingland PTAL I have moved the printing to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
Make sure standard functionality works even when HOME has different permissions
func/.config.yaml
in $HOME)/kind enhancement