fix repo on create, move warning up a function

Signed-off-by: David Fridrich <[email protected]>

cmd/root.go

@@ -64,6 +64,11 @@ Learn more about Knative at: https://knative.dev`, cfg.Name),
 	viper.SetEnvPrefix("func") // ensure that all have the prefix
 	viper.SetEnvKeyReplacer(strings.NewReplacer("-", "_"))
 
+	// check if permissions for FUNC HOME are sufficient; warn if otherwise
+	cp := config.File()
+	if _, err := os.ReadFile(cp); os.IsPermission(err) {
+		fmt.Fprintf(os.Stderr, "Warning: Insufficient permissions to read config file at '%s' - continuing without it\n", cp)
+	}
 	// Client
 	// Use the provided ClientFactory or default to NewClient
 	newClient := cfg.NewClient

pkg/config/config.go

@@ -82,13 +82,10 @@ func NewDefault() (cfg Global, err error) {
 	bb, err := os.ReadFile(cp)
 	if err != nil {
 		// config file is not required
-		if os.IsNotExist(err) {
+		// permissions warning printed in cmd/root.go as to not spam here
+		// TODO: gauron99 - review the whole process for simplification
+		if os.IsNotExist(err) || os.IsPermission(err) {
 			err = nil
-		} else if os.IsPermission(err) {
-			err = nil // insufficient perms for config file -> warning
-			// TODO: gauron99 - this gets printed out for lot of commands so its a bit
-			// spammy, perhaps dont print here?
-			fmt.Fprintf(os.Stderr, "Warning: Insufficient permissions to read config file at '%s' - continuing without it\n", cp)
 		}
 		return
 	}

pkg/functions/repositories.go

@@ -100,9 +100,9 @@ func (r *Repositories) All() (repos []Repository, err error) {
 	if r.path == "" {
 		return
 	}
-
-	// Return empty if path does not exist
-	if _, err = os.Stat(r.path); os.IsNotExist(err) {
+	fmt.Printf("repos: %v\n\n", repos)
+	// Return empty if path does not exist or insufficient permissions
+	if _, err = os.Stat(r.path); os.IsNotExist(err) || os.IsPermission(err) {
 		return repos, nil
 	}