Add observedGeneration in JobSink OpenAPI schema

[pierDipi]

Spotted via warning {"level":"warn","ts":"2024-11-04T08:27:58.926Z","logger":"controller","caller":"logging/warning_handler.go:32","msg":"API Warning: unknown field \"status.observedGeneration\"","commit":"19e4c4b-dirty","knative.dev/pod":"eventing-controller-66689fc58-n9fdh"}

Fixes #8295

Proposed Changes

• Add observedGeneration in JobSink OpenAPI schema

Pre-review Checklist

• At least 80% unit test coverage
• E2E tests for any new behavior
• Docs PR for any user-facing impact
• Spec PR for any new API feature
• Conformance test for any change to the spec

Release Note

Add observedGeneration in JobSink OpenAPI schema

/kind bug

[pierDipi]

/cherry-pick release-1.16

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/cherry-pick release-1.15

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[knative-prow-robot]

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pierDipi]

/cc @mgencur @creydr

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.58%. Comparing base (2e4d353) to head (5a1d40b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8297   +/-   ##
=======================================
  Coverage   64.58%   64.58%           
=======================================
  Files         373      373           
  Lines       22619    22619           
=======================================
  Hits        14609    14609           
  Misses       7244     7244           
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mgencur]

/lgtm

[knative-prow-robot]

@pierDipi: new pull request created: #8299

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[knative-prow-robot]

@pierDipi: new pull request created: #8300

In response to this:

/cherry-pick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Fabian-K]

Hi @pierDipi

it looks like observedGeneration was already part of config/core/resources/jobsink.yaml and is now in there twice. This leads to issues like mapping key "observedGeneration" already defined when referencing it in customize. Let me know if I should provide a PR for it.

Thanks!

[mgencur]

@Fabian-K Hey. Apparently, this was already fixed in #8168 for 1.16 and it was only a problem for 1.15.
Could you send a PR to remove it again? Thanks

[mgencur]

And the removal must be backported to 1.16 as well.