Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Add observedGeneration in JobSink OpenAPI schema #949

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Nov 4, 2024

Backport of knative#8297

Signed-off-by: Pierangelo Di Pilato <[email protected]>
@pierDipi
Copy link
Member Author

pierDipi commented Nov 4, 2024

/cherry-pick release-v1.16

@openshift-ci openshift-ci bot requested review from creydr and lberk November 4, 2024 08:48
@openshift-cherrypick-robot

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved label Nov 4, 2024
@mgencur
Copy link

mgencur commented Nov 4, 2024

/lgtm

Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bab0766 and 2 for PR HEAD 0e59e06 in total

2 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bab0766 and 2 for PR HEAD 0e59e06 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bab0766 and 2 for PR HEAD 0e59e06 in total

Copy link

openshift-ci bot commented Nov 5, 2024

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/413-test-reconciler-aws-413 0e59e06 link true /test 413-test-reconciler-aws-413
ci/prow/413-test-e2e-aws-413 0e59e06 link true /test 413-test-e2e-aws-413
ci/prow/413-test-encryption-auth-e2e-aws-413 0e59e06 link true /test 413-test-encryption-auth-e2e-aws-413

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi
Copy link
Member Author

pierDipi commented Nov 5, 2024

/retest

@pierDipi pierDipi merged commit bec5104 into openshift-knative:release-v1.15 Nov 5, 2024
19 of 38 checks passed
@pierDipi pierDipi deleted the cp-5a1d40bb5cca430a812853becc79d1924076c7a0-v1.15 branch November 5, 2024 07:40
@openshift-cherrypick-robot

@pierDipi: new pull request created: #951

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants