-
Notifications
You must be signed in to change notification settings - Fork 600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest dependencies #7190
Conversation
Signed-off-by: Christoph Stäbler <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7190 +/- ##
==========================================
- Coverage 77.93% 77.92% -0.02%
==========================================
Files 246 246
Lines 13200 13202 +2
==========================================
Hits 10288 10288
- Misses 2390 2392 +2
Partials 522 522 ☔ View full report in Codecov by Sentry. |
/hold |
eventing/pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel_test.go Lines 194 to 211 in 19ab7b7
failed run: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7190/unit-tests_eventing_main/1692134117669343232 In 8a3379c I changed the test to replace a subscriber (instead of adding and removing one and changing the order), because that way the produced patch is more predictable (and thus not flaky). It is not exactly testing, what was tested before, but IMO it's testing to replace a subscriber. Remove the |
/assign @pierDipi |
/retest |
/test upgrade-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test upgrade-tests |
The automated dependency bump in #7182 has issues with a failing unit test.
This is because gomodules.xyz/jsonpatch/v2 did some internal performance changes in gomodules/jsonpatch#36. This leads not to a
replace
patch instead of anadd
andremove
.This PR addresses it and updates the failing unit test to take this into account.