Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest dependencies #7190

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

creydr
Copy link
Member

@creydr creydr commented Aug 17, 2023

The automated dependency bump in #7182 has issues with a failing unit test.
This is because gomodules.xyz/jsonpatch/v2 did some internal performance changes in gomodules/jsonpatch#36. This leads not to a replace patch instead of an add and remove.
This PR addresses it and updates the failing unit test to take this into account.

@knative-prow knative-prow bot requested review from lberk and pierDipi August 17, 2023 11:19
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (29ac3ee) 77.93% compared to head (8a3379c) 77.92%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7190      +/-   ##
==========================================
- Coverage   77.93%   77.92%   -0.02%     
==========================================
  Files         246      246              
  Lines       13200    13202       +2     
==========================================
  Hits        10288    10288              
- Misses       2390     2392       +2     
  Partials      522      522              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

/hold
seems to be flaky

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

TestAllCases in pkg/reconciler/inmemorychannel is flaky for the case when adding a new subscriber and removing an existing and changing the order:

Name: "with subscribers, one removed one added to status",
Key: imcKey,
Objects: []runtime.Object{
NewInMemoryChannel(imcName, testNS,
WithInitInMemoryChannelConditions,
WithInMemoryChannelDeploymentReady(),
WithInMemoryChannelServiceReady(),
WithInMemoryChannelEndpointsReady(),
WithInMemoryChannelChannelServiceReady(),
WithInMemoryChannelSubscribers(subscribers),
WithInMemoryChannelReadySubscriberAndGeneration(string(subscriber3UID), subscriber3Generation),
WithInMemoryChannelReadySubscriberAndGeneration(string(subscriber1UID), subscriber1Generation),
WithInMemoryChannelAddress(channelServiceAddress)),
},
WantPatches: []clientgotesting.PatchActionImpl{
makePatch(testNS, imcName, oneSubscriberRemovedOneAddedPatch),
},
}, {

failed run: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7190/unit-tests_eventing_main/1692134117669343232
succeeded run: https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_eventing/7190/unit-tests_eventing_main/1692136356471377920

In 8a3379c I changed the test to replace a subscriber (instead of adding and removing one and changing the order), because that way the produced patch is more predictable (and thus not flaky). It is not exactly testing, what was tested before, but IMO it's testing to replace a subscriber.

Remove the /hold if you're OK with it.

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

/assign @pierDipi

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

/retest

@creydr
Copy link
Member Author

creydr commented Aug 17, 2023

/test upgrade-tests

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Aug 24, 2023

/test upgrade-tests

@knative-prow knative-prow bot merged commit 4d8da11 into knative:main Aug 24, 2023
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants