Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate calling kubetest2 via kntest #7191

Closed
wants to merge 4 commits into from

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Aug 18, 2023

Part of knative/hack#230

Proposed Changes

  • kntest is deprecated so we'll be using kubetest2 directly and amending the flags we pass through

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

NONE

Docs

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@knative-prow knative-prow bot requested review from creydr and mgencur August 18, 2023 16:29
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (08cf00f) 77.89% compared to head (54c38fc) 77.87%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7191      +/-   ##
==========================================
- Coverage   77.89%   77.87%   -0.03%     
==========================================
  Files         246      246              
  Lines       13214    13214              
==========================================
- Hits        10293    10290       -3     
- Misses       2400     2402       +2     
- Partials      521      522       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@upodroid
Copy link
Member Author

/retest

@matzew
Copy link
Member

matzew commented Aug 24, 2023

/test build-tests

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023
@matzew
Copy link
Member

matzew commented Aug 24, 2023

@upodroid looks like there is conflict?

Not sure why was the serving related PR merged so long ago? and this one just recently created?

@upodroid
Copy link
Member Author

upodroid commented Aug 24, 2023

#7190 was broken because of this change, so @creydr skipped bumping knative/hack and bumped other libs instead

I'll rebase this.

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2023
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 24, 2023
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2023
@matzew
Copy link
Member

matzew commented Aug 28, 2023

/test build-tests

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member

matzew commented Aug 28, 2023

/test build-tests

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 28, 2023

@upodroid: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
build-tests_eventing_main 54c38fc link true /test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@matzew matzew mentioned this pull request Aug 28, 2023
@knative-prow knative-prow bot closed this in #7211 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants