-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate calling kubetest2 via kntest #7191
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7191 +/- ##
==========================================
- Coverage 77.89% 77.87% -0.03%
==========================================
Files 246 246
Lines 13214 13214
==========================================
- Hits 10293 10290 -3
- Misses 2400 2402 +2
- Partials 521 522 +1 ☔ View full report in Codecov by Sentry. |
/retest |
/test build-tests |
@upodroid looks like there is conflict? Not sure why was the serving related PR merged so long ago? and this one just recently created? |
1a3c49a
to
215b64c
Compare
fdc34e9
to
483635d
Compare
/test build-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test build-tests |
@upodroid: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Part of knative/hack#230
Proposed Changes
Pre-review Checklist
Release Note
Docs