[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: cmd/jobsink/main_test.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */

Process completed with exit code 1.

Please run goimports. diff --git a/cmd/jobsink/main.go b/cmd/jobsink/main.go index 99f6b1f..d430744 100644 --- a/cmd/jobsink/main.go +++ b/cmd/jobsink/main.go @@ -19,6 +19,7 @@ package main import ( "context" "crypto/md5" + //nolint:gosec "crypto/tls" "encoding/hex" @@ -450,6 +451,6 @@ func jobLabelSelector(ref types.NamespacedName, id string) string { } func toJobName(js string, source, id string) string { - h := md5.Sum([]byte(source+id)) - return kmeta.ChildName(js, "-" + utils.ToDNS1123Subdomain(hex.EncodeToString(h[:]))) + h := md5.Sum([]byte(source + id)) + return kmeta.ChildName(js, "-"+utils.ToDNS1123Subdomain(hex.EncodeToString(h[:]))) }

Please run goimports. diff --git a/cmd/jobsink/main_test.go b/cmd/jobsink/main_test.go index 0862d40..0bf31b5 100644 --- a/cmd/jobsink/main_test.go +++ b/cmd/jobsink/main_test.go @@ -29,7 +29,7 @@ func TestToJobName(t *testing.T) { } for _, tc := range testcases { - t.Run(tc.JobSinkName + "_" + tc.Source + "_" + tc.Id, func(t *testing.T) { + t.Run(tc.JobSinkName+"_"+tc.Source+"_"+tc.Id, func(t *testing.T) { if errs := validation.NameIsDNS1035Label(tc.JobSinkName, false); len(errs) != 0 { t.Errorf("Invalid JobSinkName: %v", errs) }

Process completed with exit code 1.

G501: Blocklisted import crypto/md5: weak cryptographic primitive (gosec)

G401: Use of weak cryptographic primitive (gosec)

issues found

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum

Restore cache failed: Dependencies file is not found in /home/runner/work/eventing/eventing. Supported file pattern: go.sum