Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nrrso to SC #1521

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Add nrrso to SC #1521

merged 2 commits into from
Mar 13, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Feb 28, 2024

Changes

  • Add nrrso to SC

/kind

Fixes #

Release Note


Docs


Copy link

knative-prow bot commented Feb 28, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Add nrrso to SC

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2024
@aliok
Copy link
Member Author

aliok commented Feb 28, 2024

/hold

@nrrso can you verify the email address please? Is that the one that you would like to use?

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2024
groups/groups.yaml Outdated Show resolved Hide resolved
@aliok
Copy link
Member Author

aliok commented Feb 29, 2024

/unhold

@knative/steering-committee this PR ready to go!

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@evankanderson
Copy link
Member

/lgtm
/approve

I'm not sure if the group add will work in the same pass, but I'm willing to try it.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link

knative-prow bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aliok,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 54dec47 into knative:main Mar 13, 2024
7 checks passed
@dprotaso
Copy link
Member

Hey @nrrso you'll have a bunch of org invites - can you approve those soon. This will unblock owner updates across our repos - eg. knative/func#2229 (comment)

@dprotaso
Copy link
Member

There will be two invites - one from the knative org and the other from knative-extensions

@aliok aliok deleted the 2024-02-28-add-nrrso-to-sc branch March 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants