Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nrrso to knative orgs #1531

Closed
wants to merge 2 commits into from

Conversation

creydr
Copy link
Member

@creydr creydr commented Mar 14, 2024

@nrrso was added as a SC member in #1521.
We missed to add him to the knative orgs, which leads to invalid-owners errors on the Update community files PRs (e.g. knative/eventing#7787 (comment)).

This PR adds @nrrso as a member to the knative and knative-extensions orgs.

/assign @aliok

@creydr creydr requested a review from aliok March 14, 2024 07:26
Copy link

knative-prow bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: creydr
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 14, 2024
Copy link

knative-prow bot commented Mar 14, 2024

@creydr: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-knative-extensions-peribolos 739102e link true /test pull-knative-extensions-peribolos
pull-knative-peribolos 739102e link true /test pull-knative-peribolos

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Member Author

creydr commented Mar 14, 2024

/hold
as already in the admin list.
See https://cloud-native.slack.com/archives/C04LY4M2G49/p1710407812444999

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
@creydr
Copy link
Member Author

creydr commented Mar 14, 2024

Closing as @nrrso is in admins list already

@creydr creydr closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants