Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop archived repos and associated teams #1352

Merged
merged 1 commit into from
May 25, 2023
Merged

drop archived repos and associated teams #1352

merged 1 commit into from
May 25, 2023

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented May 23, 2023 •
edited
Loading

Fixes: #1349
Fixes: #1348

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 23, 2023
@dprotaso
Copy link
Member Author

/assign @psschwei

@dprotaso dprotaso mentioned this pull request May 23, 2023
Merged
@dprotaso
Copy link
Member Author

/retest

@psschwei
Copy link
Contributor

/hold
Still have one internal thread on async to resolve before archiving

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2023
@psschwei
Copy link
Contributor

All good
/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023
psschwei
psschwei approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2023
@knative-prow
Copy link

knative-prow bot commented May 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit ce59ce5 into knative:main May 25, 2023
@dprotaso dprotaso deleted the drop-archived-repos branch May 25, 2023 13:45
@ReToCode ReToCode mentioned this pull request Jun 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei approved these changes

@evankanderson evankanderson Awaiting requested review from evankanderson

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Archive knative-sandbox/async-component Archive knative-sandbox/scaling-group
2 participants
@dprotaso @psschwei