Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[peribolos] allow archiving #3833

Merged
merged 1 commit into from
May 23, 2023
Merged

[peribolos] allow archiving #3833

merged 1 commit into from
May 23, 2023

Conversation

dprotaso
Copy link
Member

@knative-prow
Copy link

knative-prow bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2023
@krsna-m
Copy link
Contributor

krsna-m commented May 23, 2023

more context https://github.com/kubernetes/test-infra/blob/76032326e1e867159f36c5297aaa9e270a24d2df/prow/cmd/peribolos/main.go#L95

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@knative-prow knative-prow bot merged commit c8d9849 into knative:main May 23, 2023
@knative-prow
Copy link

knative-prow bot commented May 23, 2023

@dprotaso: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key peribolos.yaml using file prow/jobs/custom/peribolos.yaml

In response to this:

Unblocks knative/community#1352

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso deleted the allow-archive-peribolos branch May 23, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@psschwei psschwei Awaiting requested review from psschwei

Assignees

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprotaso @krsna-m