-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] refactor http input to trigger each specific action, from GET, POST, PUT and FILES #187
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,10 +7,11 @@ | |
class Input | ||
{ | ||
/** | ||
* check if the submission form is a port action | ||
* @param $type | ||
* @return bool | ||
*/ | ||
public static function exists($type = "POST") | ||
public static function exists($type = "POST"): bool | ||
{ | ||
switch ($type) { | ||
case "POST": | ||
|
@@ -41,51 +42,46 @@ private static function put(): array | |
} | ||
|
||
/** | ||
* extract data from submit form as form data | ||
* @param $file_input | ||
* @return array|string[] | ||
* @return array | ||
*/ | ||
private static function extractFromFormData($file_input) | ||
private static function extractFromFormData($file_input): array | ||
{ | ||
$fragma = []; | ||
$form_data_fragmentation = []; | ||
$explode = explode("\r", implode("\r", explode("\n", $file_input))); | ||
$len_Arr = count($explode); | ||
for ($i = 1; $i < $len_Arr; $i++) { | ||
if (!strchr($explode[$i], "----------------------------")) { | ||
if (strlen($explode[$i]) > 0) { | ||
$replaced = str_replace("Content-Disposition: form-data; name=", "", $explode[$i]); | ||
array_push($fragma, $replaced); | ||
$form_data_fragmentation[] = $replaced; | ||
} | ||
} | ||
} | ||
$len_object = count($fragma); | ||
$len_object = count($form_data_fragmentation); | ||
Comment on lines
+51
to
+62
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Load data from form-data should be revised, refactoring and validate while load form-data submission. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you're right |
||
$object = []; | ||
for ($j = 0; $j < $len_object; $j++) { | ||
if ($j == 0 || ($j + 1) % 2 != 0) { | ||
$key = str_replace("\"", "", $fragma[$j]); | ||
$object = array_merge($object, [$key => trim($fragma[($j + 1)])]); | ||
$key = str_replace("\"", "", $form_data_fragmentation[$j]); | ||
$object = array_merge($object, [$key => trim($form_data_fragmentation[($j + 1)])]); | ||
} | ||
} | ||
return $object; | ||
} | ||
|
||
/** | ||
* Access data information from $_GET action of url request | ||
* @param $item | ||
* @return mixed|null | ||
*/ | ||
static function get($item) | ||
{ | ||
$object_data = self::put(); | ||
if (isset($_POST[$item])) { | ||
return $_POST[$item]; | ||
} else if (isset($_GET[$item])) { | ||
return $_GET[$item]; | ||
} else if (isset($object_data[$item])) { | ||
return $object_data[$item]; | ||
} | ||
return null; | ||
bim-g marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return $_GET[$item] ?? null; | ||
} | ||
|
||
/** | ||
* Access HEADER data information from header | ||
* Extract header data information | ||
* @param $item | ||
* @return mixed|null | ||
|
@@ -100,10 +96,35 @@ public static function header($item) | |
} | ||
|
||
/** | ||
* @return array|null | ||
* Lists params submitted via POST, PATCH or PUT action event | ||
* @return array | ||
*/ | ||
public static function body() | ||
public static function body(): ?array | ||
{ | ||
return isset($_POST) && !empty($_POST) ? $_POST : !empty(self::put() ? self::put() : null); | ||
return !empty($_POST) ? $_POST : (!empty(self::put()) ? self::put() : null); | ||
} | ||
|
||
/** | ||
* Access data information from POST or PUT action event | ||
* @param $item | ||
* @return mixed|string|null | ||
*/ | ||
public static function post($item){ | ||
$self_put = self::put(); | ||
if (isset($_POST[$item])) { | ||
return $_POST[$item]; | ||
} else if (isset($self_put[$item])) { | ||
return $self_put[$item]; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think is better to have a form-data method to avoid confusion. |
||
} | ||
return null; | ||
} | ||
|
||
/** | ||
* Access data information from file upload event | ||
* @param string $item | ||
* @return mixed|null | ||
*/ | ||
public static function file(string $item) { | ||
return $_FILES[$item] ?? null; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this example could be on another commit of example