[ENH] refactor http input to trigger each specific action, from GET, POST, PUT and FILES #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bim-g
commented
Jun 25, 2024
| @@ -36,7 +36,7 @@ function home() | |||
| */ | |||
| function changeLang() | |||
| { | |||
| Session::put('lang', Input::get("lang")); | |||
| Session::put('lang', Input::post("lang")); | |||
There was a problem hiding this comment.
this example could be on another commit of example
Comment on lines
-77
to
-85
| $object_data = self::put(); | ||
| if (isset($_POST[$item])) { | ||
| return $_POST[$item]; | ||
| } else if (isset($_GET[$item])) { | ||
| return $_GET[$item]; | ||
| } else if (isset($object_data[$item])) { | ||
| return $object_data[$item]; | ||
| } | ||
| return null; |
There was a problem hiding this comment.
This approach make everything clean
Comment on lines
+51
to
+62
| $form_data_fragmentation = []; | ||
| $explode = explode("\r", implode("\r", explode("\n", $file_input))); | ||
| $len_Arr = count($explode); | ||
| for ($i = 1; $i < $len_Arr; $i++) { | ||
| if (!strchr($explode[$i], "----------------------------")) { | ||
| if (strlen($explode[$i]) > 0) { | ||
| $replaced = str_replace("Content-Disposition: form-data; name=", "", $explode[$i]); | ||
| array_push($fragma, $replaced); | ||
| $form_data_fragmentation[] = $replaced; | ||
| } | ||
| } | ||
| } | ||
| $len_object = count($fragma); | ||
| $len_object = count($form_data_fragmentation); |
There was a problem hiding this comment.
Load data from form-data should be revised, refactoring and validate while load form-data submission.
The process is not clean and testable.
| if (isset($_POST[$item])) { | ||
| return $_POST[$item]; | ||
| } else if (isset($self_put[$item])) { | ||
| return $self_put[$item]; |
There was a problem hiding this comment.
I think is better to have a form-data method to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to used
Input::get()method to read data from http requestGET,POSTandPUTwithout any distinction, that lead for some confusion, in case we want to deal with post, put, there was not a specific way to deal with.The approach to have each method for a specific case it makes the module more readable and more mature, and void confusion.