Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBL-1960] Using PLOT localized strings #2238

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[MBL-1960] Using PLOT localized strings #2238

wants to merge 3 commits into from
+64 −34

Conversation

jovaniks
Copy link
Contributor

@jovaniks jovaniks commented Jan 9, 2025

📲 What

Replace the hardcoded PLOT strings using localized Strings (Strings.wift)

🤔 Why

We support multiple languages

🛠 How

Implementing Strings.swift

👀 See

Before 🐛 After 🦋

✅ Acceptance criteria

  • The PLOT strings should be translated

⏰ TODO

  • Update Collection plan string (MR merged - waiting for translations teams)
  • Update the Payment Schedule (MR merged - waiting for translations teams)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottkicks scottkicks Awaiting requested review from scottkicks

@amy-at-kickstarter amy-at-kickstarter Awaiting requested review from amy-at-kickstarter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jovaniks