Port v1.5.2 bugfixes into dev-v2.0.0 #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run_inference was only accepting a single input image, this makes it accept a list of images too, and makes it so --force-nnunet-model T1T2w grabs both T1w and T2w as inputs.
this didn't affect any workflow computations, just the subsequent dscalar.nii and spec file that would have the wrong curvature map
FIX: input images when using T1T2w model
FIX: hipp curvature was being used always, instead of wildcard
Ports the bugfix PRs from v1.5.2 into this dev branch..
jordandekraker
approved these changes
Dec 16, 2024
jordandekraker
added a commit
that referenced
this pull request
Dec 16, 2024
* fix for using T1T2w model run_inference was only accepting a single input image, this makes it accept a list of images too, and makes it so --force-nnunet-model T1T2w grabs both T1w and T2w as inputs. * hipp curvature was being used always, instead of wildcard this didn't affect any workflow computations, just the subsequent dscalar.nii and spec file that would have the wrong curvature map * fix logical error * Bump version to 1.5.2-pre.1 * Bump version to 1.5.2-pre.2 * keep pipeline_description changes --------- Co-authored-by: Ali Khan <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jordandekraker
added a commit
that referenced
this pull request
Dec 17, 2024
* removed segT*w * cropseg to manualseg * Port v1.5.2 bugfixes into dev-v2.0.0 (#329) (#331) * fix for using T1T2w model run_inference was only accepting a single input image, this makes it accept a list of images too, and makes it so --force-nnunet-model T1T2w grabs both T1w and T2w as inputs. * hipp curvature was being used always, instead of wildcard this didn't affect any workflow computations, just the subsequent dscalar.nii and spec file that would have the wrong curvature map * fix logical error * Bump version to 1.5.2-pre.1 * Bump version to 1.5.2-pre.2 * keep pipeline_description changes --------- Co-authored-by: Ali Khan <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * minor bugfix for passing modality * lint * cleaned more instances of segTxw * lint * removed unneeded def --------- Co-authored-by: Jordan DeKraker <[email protected]> Co-authored-by: Ali Khan <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PRs #321 and #320 didn't make it into the base dev-2.0.0 branch, this PR ports those changes in.