Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(developer): remove paths from tsconfig.json #12028

Merged
merged 2 commits into from
Jul 27, 2024
Merged

fix(developer): remove paths from tsconfig.json #12028

merged 2 commits into from
Jul 27, 2024

Conversation

mcdurdin
Copy link
Member

@mcdurdin mcdurdin commented Jul 26, 2024 •
edited
Loading

Fixes: #12027

This addresses the build failure in the parent PR #12017.

@keymanapp-test-bot skip

@mcdurdin
fix(developer): cleanup package.json and build.sh errant references
db904b5 
During analysis of root causes for #12027, discovered a few package
relationship issues in package.json and build.sh.

analyzer-messages.ts ///<reference> is a mitigation for now.

Relates-to: #12027
@mcdurdin
fix(developer): remove paths from tsconfig.json
1afa4be 
Fixes: #12027
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Jul 26, 2024
@keymanapp-test-bot
Copy link

keymanapp-test-bot bot commented Jul 26, 2024 •
edited
Loading

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S7 milestone Jul 26, 2024
mcdurdin
mcdurdin commented Jul 26, 2024
View reviewed changes
developer/src/.gitignore
@@ -86,3 +86,4 @@ kmc/build/
kmc-*/build/


setup/icons.res
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but not worthy of its own PR

developer/src/kmc-kmn/package.json
"@keymanapp/keyman-version": "*",
"@keymanapp/developer-utils": "*",
"@keymanapp/kmc-kmn": "*"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird huh?

package.json
@@ -3,7 +3,7 @@
"private": true,
"devDependencies": {
"@microsoft/api-documenter": "^7.23.31",
"@microsoft/api-extractor": "^7.41.0",
"@microsoft/api-extractor": "^7.47.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brings api extractor's bundled TS up to 5.4.2 (we are on 5.4.5).

@mcdurdin mcdurdin marked this pull request as ready for review July 26, 2024 01:22
@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-missing User tests have not yet been defined for the PR label Jul 26, 2024
@mcdurdin mcdurdin requested a review from jahorton July 26, 2024 01:23
@mcdurdin mcdurdin linked an issue Jul 26, 2024 that may be closed by this pull request
chore(developer): remove 'paths' from tsconfig.json #12027
Closed
ermshiperete
ermshiperete approved these changes Jul 26, 2024
View reviewed changes
developer/src/common/web/utils/test/tsconfig.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but we should consider renaming developer/src/common/web - it's too easy to confuse with common/web/utils and @keymanapp/web-utils. web in the case of developer refers to the technology/programming language, not the target. Maybe developer/src/common/ts or developer/src/common/webtech or developer/src/common/node?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But by that argument common/web/utils should also be common/ts/utils 😁 and so the confusion remains. Can consider this but let's finish sorting out the chaos of KeymanWeb-specific modules in /common first!

developer/src/kmc-analyze/src/analyzer-messages.ts
@@ -1,3 +1,6 @@
/// <reference types="@keymanapp/common-types" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: This is still required, even with the paths removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now, see comments on subsequent lines. It may be possible to do this with an import type declaration but I haven't figured out what is needed yet. This works, and we are still much better off without the noise in tsconfig.json...

This was referenced Jul 26, 2024
Closed
Merged
Merged
Base automatically changed from chore/developer/10254-analyzer-messages to master July 27, 2024 01:34
@mcdurdin mcdurdin merged commit 2f6ffd9 into master Jul 27, 2024
5 checks passed
@mcdurdin mcdurdin deleted the fix/developer/12027-remove-paths-from-tsconfig.json branch July 27, 2024 01:34
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.77-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermshiperete ermshiperete ermshiperete approved these changes

@darcywong00 darcywong00 Awaiting requested review from darcywong00 darcywong00 is a code owner

@jahorton jahorton Awaiting requested review from jahorton

Assignees
No one assigned
Labels
developer/compilers/ developer/ide/ developer/ fix
Projects
None yet
Milestone
A18S7
Development

Successfully merging this pull request may close these issues.

chore(developer): remove 'paths' from tsconfig.json
3 participants
@mcdurdin @keyman-server @ermshiperete