-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(developer): remove 'paths' from tsconfig.json #12027
Comments
mcdurdin
changed the title
chore(developer): remove 'paths' from tsconfig.json
chore(developer, common): remove 'paths' from tsconfig.json
Jul 25, 2024
mcdurdin
changed the title
chore(developer, common): remove 'paths' from tsconfig.json
chore(developer): remove 'paths' from tsconfig.json
Jul 25, 2024
ermshiperete
added a commit
that referenced
this issue
Jul 26, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
ermshiperete
added a commit
that referenced
this issue
Jul 26, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
ermshiperete
added a commit
that referenced
this issue
Jul 26, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
ermshiperete
added a commit
that referenced
this issue
Jul 26, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
ermshiperete
added a commit
that referenced
this issue
Jul 26, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
mcdurdin
added a commit
that referenced
this issue
Jul 26, 2024
With the full move to ES Modules, we no longer need to include `references` in tsconfig.json, as we can rely on package.json and build.sh dependency management. Note however that `tsc -b` may not work to build dependencies -- they need to be built using `build.sh`, which calculates which dependencies need building. kmc-keyboard-info was missing a dependency link to kmc-package in build.sh, correcting this at the same time. Relates-to: #12027
ermshiperete
added a commit
that referenced
this issue
Jul 29, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
ermshiperete
added a commit
that referenced
this issue
Jul 30, 2024
See #12027 (as well as build failures in the current repo restructurings) for the motivation for this change. Basically remove all `path` lines from `references` except when they reference files in or below the current directory. Another execption is if there is no `package.json` file for the current directory, i.e. the current directory is not a separate module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per https://www.typescriptlang.org/docs/handbook/modules/reference.html#paths:
It looks like this may be responsible for the build failure described in #10254.
The text was updated successfully, but these errors were encountered: