change(web): move KeyboardProcessor.Codes into common/web/types 🏗️ #11913

ermshiperete · 2024-07-02T17:45:34Z

Fixes: #8146

@keymanapp-test-bot skip

keymanapp-test-bot · 2024-07-02T17:45:46Z

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

Android
Developer
iOS
- Keyman for iOS (simulator image)
- FirstVoices Keyboards for iOS (simulator image)
- TestFlight internal PR build version - 18.0.66 (0.11913.11550)
Keyboards
- Test Keyboards
Web
- KeymanWeb Test Home
Windows

Also add some trivial unit tests for `Codes` to satisfy coverage threshold. Fixes: #8146

mcdurdin

Thank you for this refactor PR. I am going to requesting a significant change here.

I would like to be careful about what we move into common/types. I am already trying to extricate myself from Developer-specific files that I put there, so don't want to do the same thing for KeymanWeb-specific content.

The constants in codes.ts do belong in common/types -- but they are nearly all already there, in kmx.ts:

keyman/common/web/types/src/kmx/kmx.ts

Lines 346 to 364 in 3497e97

    
           public static readonly LCTRLFLAG =   0x0001;    // Left Control flag 
        
           public static readonly RCTRLFLAG =   0x0002;    // Right Control flag 
        
           public static readonly LALTFLAG =    0x0004;    // Left Alt flag 
        
           public static readonly RALTFLAG =    0x0008;    // Right Alt flag 
        
           public static readonly K_SHIFTFLAG = 0x0010;    // Either shift flag 
        
           public static readonly K_CTRLFLAG =  0x0020;    // Either ctrl flag 
        
           public static readonly K_ALTFLAG =   0x0040;    // Either alt flag 
        
           //public static readonly K_METAFLAG =  0x0080;    // Either Meta-key flag (tentative).  Not usable in keyboard rules; 
        
                                           // Used internally (currently, only by KMW) to ensure Meta-key 
        
                                           // shortcuts safely bypass rules 
        
                                           // Meta key = Command key on macOS, Windows key on Windows 
        
           public static readonly CAPITALFLAG    = 0x0100;    // Caps lock on 
        
           public static readonly NOTCAPITALFLAG = 0x0200;    // Caps lock NOT on 
        
           public static readonly NUMLOCKFLAG    = 0x0400;    // Num lock on 
        
           public static readonly NOTNUMLOCKFLAG = 0x0800;    // Num lock NOT on 
        
           public static readonly SCROLLFLAG     = 0x1000;    // Scroll lock on 
        
           public static readonly NOTSCROLLFLAG  = 0x2000;    // Scroll lock NOT on 
        
           public static readonly ISVIRTUALKEY   = 0x4000;    // It is a Virtual Key Sequence 
        
           public static readonly VIRTUALCHARKEY = 0x8000;    // Keyman 6.0: Virtual Key Cap Sequence NOT YET

and virtual-key-constants.ts:

keyman/common/web/types/src/consts/virtual-key-constants.ts

Lines 5 to 143 in 2b2661b

    
           /** 
        
            * May include non-US virtual key codes 
        
            */ 
        
           export const USVirtualKeyCodes = { 
        
             K_BKSP:8, 
        
             K_TAB:9, 
        
             K_ENTER:13, 
        
             K_SHIFT:16, 
        
             K_CONTROL:17, 
        
             K_ALT:18, 
        
             K_PAUSE:19, 
        
             K_CAPS:20, 
        
             K_ESC:27, 
        
             K_SPACE:32, 
        
             K_PGUP:33, 
        
             K_PGDN:34, 
        
             K_END:35, 
        
             K_HOME:36, 
        
             K_LEFT:37, 
        
             K_UP:38, 
        
             K_RIGHT:39, 
        
             K_DOWN:40, 
        
             K_SEL:41, 
        
             K_PRINT:42, 
        
             K_EXEC:43, 
        
             K_INS:45, 
        
             K_DEL:46, 
        
             K_HELP:47, 
        
             K_0:48, 
        
             K_1:49, 
        
             K_2:50, 
        
             K_3:51, 
        
             K_4:52, 
        
             K_5:53, 
        
             K_6:54, 
        
             K_7:55, 
        
             K_8:56, 
        
             K_9:57, 
        
             K_A:65, 
        
             K_B:66, 
        
             K_C:67, 
        
             K_D:68, 
        
             K_E:69, 
        
             K_F:70, 
        
             K_G:71, 
        
             K_H:72, 
        
             K_I:73, 
        
             K_J:74, 
        
             K_K:75, 
        
             K_L:76, 
        
             K_M:77, 
        
             K_N:78, 
        
             K_O:79, 
        
             K_P:80, 
        
             K_Q:81, 
        
             K_R:82, 
        
             K_S:83, 
        
             K_T:84, 
        
             K_U:85, 
        
             K_V:86, 
        
             K_W:87, 
        
             K_X:88, 
        
             K_Y:89, 
        
             K_Z:90, 
        
             K_NP0:96, 
        
             K_NP1:97, 
        
             K_NP2:98, 
        
             K_NP3:99, 
        
             K_NP4:100, 
        
             K_NP5:101, 
        
             K_NP6:102, 
        
             K_NP7:103, 
        
             K_NP8:104, 
        
             K_NP9:105, 
        
             K_NPSTAR:106, 
        
             K_NPPLUS:107, 
        
             K_SEPARATOR:108, 
        
             K_NPMINUS:109, 
        
             K_NPDOT:110, 
        
             K_NPSLASH:111, 
        
             K_F1:112, 
        
             K_F2:113, 
        
             K_F3:114, 
        
             K_F4:115, 
        
             K_F5:116, 
        
             K_F6:117, 
        
             K_F7:118, 
        
             K_F8:119, 
        
             K_F9:120, 
        
             K_F10:121, 
        
             K_F11:122, 
        
             K_F12:123, 
        
             K_NUMLOCK:144, 
        
             K_SCROLL:145, 
        
             K_LSHIFT:160, 
        
             K_RSHIFT:161, 
        
             K_LCONTROL:162, 
        
             K_RCONTROL:163, 
        
             K_LALT:164, 
        
             K_RALT:165, 
        
             K_COLON:186, 
        
             K_EQUAL:187, 
        
             K_COMMA:188, 
        
             K_HYPHEN:189, 
        
             K_PERIOD:190, 
        
             K_SLASH:191, 
        
             K_BKQUOTE:192, 
        
             K_LBRKT:219, 
        
             /** 
        
              * == K_OEM_5, 0xDC 
        
              */ 
        
             K_BKSLASH:220, 
        
             K_RBRKT:221, 
        
             K_QUOTE:222, 
        
             /** 
        
              * ISO B00, key to right of left shift, not on US keyboard, 
        
              * 0xE2, K_OEM_102 
        
              */ 
        
             K_oE2:226, 
        
             K_OE2:226, 
        
             K_oC1:193,  // ISO B11, ABNT-2 key to left of right shift, not on US keyboard 
        
             K_OC1:193, 
        
             'K_?C1':193, 
        
             'k_?C1':193, 
        
             K_oDF:0xDF, 
        
             K_ODF:0xDF, 
        
             /*K_LOPT:50001, 
        
             K_ROPT:50002, 
        
             K_NUMERALS:50003, 
        
             K_SYMBOLS:50004, 
        
             K_CURRENCIES:50005, 
        
             K_UPPER:50006, 
        
             K_LOWER:50007, 
        
             K_ALPHA:50008, 
        
             K_SHIFTED:50009, 
        
             K_ALTGR:50010, 
        
             K_TABBACK:50011, 
        
             K_TABFWD:50012*/ 
        
           };

Given this, I am not sure that this move makes sense -- we don't solve the WETness of the constants. So here's an alternate proposal:

consider a reorg of kmx.ts to move modifier constants into consts/modifier-key-constants.ts (and re-export them from kmx.ts to maintain 100% API surface consistency)
keep codes.ts in keyboard-processor
harmonize any inconsistencies between the constants in codes.ts and modifier-key-constants.ts / virtual-key-constants.ts. This may mean adding some constants to those two files (but without changing the pattern in which they are declared.)
finally, remove the constant declarations from codes.ts, and instead import and re-export the ones found in modifier-key-constants.ts / virtual-key-constants.ts. If necessary, add wrappers so that we can match the way kmw currently uses the constants. (Avoid rewriting other aspects of kmw at this point)

I think this would make the change quite a lot smaller, as most of the references in kmw wouldn't change, just codes.ts. It would also address the WETness, which IMO is the primary driver for this refactor.

I appreciate that this is a big change request -- but really feel like it will result in a better outcome.

Note: some of my comments added in this review probably become irrelevant in light of this more fundamental change request

mcdurdin · 2024-07-30T22:29:00Z

common/web/types/src/consts/codes.ts

-    var modifier=0;
+    let modifier=0;


Is there a reason these were changed in this PR? I would prefer not to have even minimal changes like this in a refactor PR

mcdurdin · 2024-07-30T22:29:03Z

common/web/types/src/consts/codes.ts

 // We should start splitting off code needed by keyboards even without a KeyboardProcessor active.

 // see also: common/web/types/src/kmx/kmx.ts

-const Codes = {
+export const Codes = {


This is a overly broad export name! Can we rename it? KeyCodes?

mcdurdin · 2024-07-30T22:30:20Z

common/web/types/test/types/consts/test-codes.ts

+      ].forEach(keyId => assert.isTrue(Codes.isFrameKey(keyId), `isFrameKey(${keyId})`));
+
+      [
+        'K_ESC',


This should be a frame key, shouldn't it? But a job for a future PR if so.

mcdurdin · 2024-07-30T22:30:35Z

common/web/types/test/types/consts/test-codes.ts

+        'K_ALT',  // not currently included in isFrameKey
+        'K_CTRL', // not currently included in isFrameKey


These also should be frame keys, shouldn't they? But also a job for a future PR if so.

mcdurdin · 2024-07-30T22:31:15Z

common/web/types/test/types/consts/test-codes.ts

+  });
+
+  describe('test getModifierState()', function () {
+    it('should properly identify modifiers from layer id', () => {


I think many of these layerIds are deprecated, and it would be good to split tests for deprecated layerIds out.

mcdurdin · 2024-07-30T22:34:56Z

web/src/engine/osk/src/index.ts

@@ -1,4 +1,4 @@
-export { Codes, DeviceSpec, Keyboard, KeyboardProperties, SpacebarText } from '@keymanapp/keyboard-processor';
+export { DeviceSpec, Keyboard, KeyboardProperties, SpacebarText } from '@keymanapp/keyboard-processor';


Should Codes be re-exported, given it was exported here before? I don't know how "public" these exports are... @jahorton? (And if we rename Codes then perhaps its name should be maintained here export { KeyCodes as Codes } from '@keymanapp/common-types';?)

Considering that we only even modularized to this extent with Keyman 17, I severely doubt anyone external is relying upon Codes here. If everything is building fine, we're good.

I would be a touch worried about Web's test-sequence "recording" module... but that's built via ./web/build.sh tools, which is triggered during standard Web CI builds. As even that didn't fall over, in the absolute worst case, all that would be needed is to tidy up the relevant pages.

tl;dr: nah, no need to re-export.

mcdurdin · 2024-07-30T22:39:12Z

common/web/types/src/consts/codes.ts

@@ -115,13 +114,13 @@ const Codes = {
   * @return      {number}                    modifier key state (desktop keyboards)
   */
   getModifierState(layerId: string): number {


I don't think any of the functions in this file should be moved over -- just the constants. These functions should stay in KeymanWeb's source, because they are not generic nor consistent enough to be put into common/types.

mcdurdin · 2024-07-30T22:40:43Z

common/web/types/src/consts/codes.ts

@@ -1,9 +1,8 @@
-// TODO:  Move to separate folder:  'codes'
 // We should start splitting off code needed by keyboards even without a KeyboardProcessor active.


This line should be deleted; and we need a header.

Suggested change

// We should start splitting off code needed by keyboards even without a KeyboardProcessor active.

/*

* Keyman is copyright (C) SIL International. MIT License.

*

* Keyboard key codes and modifier bitmasks.

*/

mcdurdin · 2024-07-30T22:42:10Z

common/web/keyboard-processor/src/index.ts

-export { default as Codes } from "./text/codes.js";
-export * from "./text/codes.js";


This is not great (double-exporting and flattening of exports like this) and I am glad it's gone ... but do we need to maintain the exports for compatibility? @jahorton

Also exported in web/src/engine/osk/src/index.ts (why?)

Eh, if it builds, I assume it's fine. Standard Web CI builds even build the development tools, which would be the only thing I'd worry about falling over. (They'd fail the build if they fell over.)

jahorton · 2024-07-31T01:45:23Z

[...]

harmonize any inconsistencies between the constants in codes.ts and modifier-key-constants.ts / virtual-key-constants.ts. This may mean adding some constants to those two files (but without changing the pattern in which they are declared.)

finally, remove the constant declarations from codes.ts, and instead import and re-export the ones found in modifier-key-constants.ts / virtual-key-constants.ts. If necessary, add wrappers so that we can match the way kmw currently uses the constants. (Avoid rewriting other aspects of kmw at this point)

Why would we not just rework the definition patterns to be consistent for each Codes property? The excerpted USVirtualKeyCodes pattern is an exact-match, save maybe for some constant names. Is there a particular reason not to rework the following block to use a similar format? I think it'd be better for maintenance than having to assign each constant (as below / in kmx) to an object (as provided within Codes) as a separate step.

keyman/common/web/types/src/kmx/kmx.ts

Lines 346 to 364 in 3497e97

public static readonly LCTRLFLAG = 0x0001; // Left Control flag

public static readonly RCTRLFLAG = 0x0002; // Right Control flag

public static readonly LALTFLAG = 0x0004; // Left Alt flag

public static readonly RALTFLAG = 0x0008; // Right Alt flag

public static readonly K_SHIFTFLAG = 0x0010; // Either shift flag

public static readonly K_CTRLFLAG = 0x0020; // Either ctrl flag

public static readonly K_ALTFLAG = 0x0040; // Either alt flag

//public static readonly K_METAFLAG = 0x0080; // Either Meta-key flag (tentative). Not usable in keyboard rules;

// Used internally (currently, only by KMW) to ensure Meta-key

// shortcuts safely bypass rules

// Meta key = Command key on macOS, Windows key on Windows

public static readonly CAPITALFLAG = 0x0100; // Caps lock on

public static readonly NOTCAPITALFLAG = 0x0200; // Caps lock NOT on

public static readonly NUMLOCKFLAG = 0x0400; // Num lock on

public static readonly NOTNUMLOCKFLAG = 0x0800; // Num lock NOT on

public static readonly SCROLLFLAG = 0x1000; // Scroll lock on

public static readonly NOTSCROLLFLAG = 0x2000; // Scroll lock NOT on

public static readonly ISVIRTUALKEY = 0x4000; // It is a Virtual Key Sequence

public static readonly VIRTUALCHARKEY = 0x8000; // Keyman 6.0: Virtual Key Cap Sequence NOT YET

Granted, some of the constant names differ from what's in Codes... but I'd think it wise to sync up the names. I'm all for renaming the constants currently within Web to match what's here, rather than maintaining Web-specific aliases.

I do understand we'd probably need a wrapper to "bundle" all the codes into their "final form" - as properties of Web's current Codes object format - that much makes sense.

mcdurdin · 2024-07-31T01:51:31Z

Why would we not just rework the definition patterns to be consistent for each Codes property? The excerpted USVirtualKeyCodes pattern is an exact-match, save maybe for some constant names. Is there a particular reason not to rework the following block to use a similar format? I think it'd be better for maintenance than having to assign each constant (as below / in kmx) to an object (as provided within Codes) as a separate step.

I would like to avoid a cascade of changes into Developer at this point -- there are many changes happening in Developer at the same time. That block is a match for kmx_file.h, also.

But we could certainly put an object wrapper into common/types (that is then imported into Codes.ts). Then at least the wrapper and the original definitions are in the same place.

ermshiperete · 2024-07-31T16:30:01Z

So in our discussion, we said that we'd like to keep the

  public static readonly LCTRLFLAG = 0x0001;      // Left Control flag
  public static readonly RCTRLFLAG = 0x0002;      // Right Control flag

syntax because that's used in Developer. However, Codes.modifierKeys which is implemented as

  modifierCodes: {
    "LCTRL":0x0001,           // LCTRLFLAG
    "RCTRL":0x0002,           // RCTRLFLAG
    ...
  } as {[name: string]: number},

is also used in Developer (via MinimalCodesInterface). The comment in keyboardHarness.ts says:

Defines any public API points used by debug-compiled keyboards for human-readable

nomenclature in rules within a Keyman keyboard's script for keyboard rules.

Refer to C:\keymanapp\keyman\developer\src\tike\compile\CompileKeymanWeb.pas,

TCompileKeymanWeb.JavaScript_SetupDebug.

Is this still true? Then we will need both?

mcdurdin · 2024-07-31T22:34:59Z

Is this still true? Then we will need both?

Yes, we'll need both. Keyboards build with Debug configuration have references to modifierCodes and keyCodes. See how debug-build keyboards use it, for example:

https://gist.github.com/mcdurdin/1aeedf74c2127165bc63f705d41b3292#file-khmer_angkor-js-L9-L10

  var modCodes = keyman.osk.modifierCodes;
  var keyCodes = keyman.osk.keyCodes;

ermshiperete · 2024-08-01T17:12:34Z

Superseded by #12072

ermshiperete requested review from jahorton and mcdurdin as code owners July 2, 2024 17:45

github-actions bot added web/ common/ common/web/ change Minor change in functionality, but not new labels Jul 2, 2024

keymanapp-test-bot bot added this to the A18S5 milestone Jul 2, 2024

ermshiperete marked this pull request as draft July 2, 2024 21:06

ermshiperete linked an issue Jul 2, 2024 that may be closed by this pull request

chore(web): move KeyboardProcessor.Codes into common/web/types #8146

Closed

ermshiperete modified the milestones: A18S5, A18S7 Jul 3, 2024

ermshiperete force-pushed the change/web/8146_moveCodes branch 2 times, most recently from 6fecc73 to 1798b7a Compare July 4, 2024 16:42

ermshiperete force-pushed the change/web/11878_remove-es5 branch from 68a1330 to a1bdce0 Compare July 4, 2024 16:52

ermshiperete force-pushed the change/web/8146_moveCodes branch from 1798b7a to f5d4587 Compare July 4, 2024 16:53

ermshiperete force-pushed the change/web/11878_remove-es5 branch from a1bdce0 to 2d9d847 Compare July 4, 2024 18:49

ermshiperete force-pushed the change/web/8146_moveCodes branch from f5d4587 to f17f847 Compare July 4, 2024 18:55

ermshiperete force-pushed the change/web/8146_moveCodes branch 5 times, most recently from 03d8994 to bd732fa Compare July 29, 2024 15:46

change(web): move KeyboardProcessor.Codes into common/web/types

3fcb6c2

Also add some trivial unit tests for `Codes` to satisfy coverage threshold. Fixes: #8146

ermshiperete force-pushed the change/web/8146_moveCodes branch from bd732fa to 3fcb6c2 Compare July 30, 2024 09:42

ermshiperete changed the title ~~change(web): move KeyboardProcessor.Codes into common/web/types~~ change(web): move KeyboardProcessor.Codes into common/web/types 🏗️ Jul 30, 2024

ermshiperete marked this pull request as ready for review July 30, 2024 13:57

mcdurdin requested changes Jul 30, 2024

View reviewed changes

Base automatically changed from change/web/11878_remove-es5 to master July 31, 2024 15:48

ermshiperete closed this Aug 1, 2024

ermshiperete deleted the change/web/8146_moveCodes branch August 1, 2024 17:12

	public static readonly LCTRLFLAG = 0x0001; // Left Control flag
	public static readonly RCTRLFLAG = 0x0002; // Right Control flag
	public static readonly LALTFLAG = 0x0004; // Left Alt flag
	public static readonly RALTFLAG = 0x0008; // Right Alt flag
	public static readonly K_SHIFTFLAG = 0x0010; // Either shift flag
	public static readonly K_CTRLFLAG = 0x0020; // Either ctrl flag
	public static readonly K_ALTFLAG = 0x0040; // Either alt flag
	//public static readonly K_METAFLAG = 0x0080; // Either Meta-key flag (tentative). Not usable in keyboard rules;
	// Used internally (currently, only by KMW) to ensure Meta-key
	// shortcuts safely bypass rules
	// Meta key = Command key on macOS, Windows key on Windows
	public static readonly CAPITALFLAG = 0x0100; // Caps lock on
	public static readonly NOTCAPITALFLAG = 0x0200; // Caps lock NOT on
	public static readonly NUMLOCKFLAG = 0x0400; // Num lock on
	public static readonly NOTNUMLOCKFLAG = 0x0800; // Num lock NOT on
	public static readonly SCROLLFLAG = 0x1000; // Scroll lock on
	public static readonly NOTSCROLLFLAG = 0x2000; // Scroll lock NOT on
	public static readonly ISVIRTUALKEY = 0x4000; // It is a Virtual Key Sequence
	public static readonly VIRTUALCHARKEY = 0x8000; // Keyman 6.0: Virtual Key Cap Sequence NOT YET

	/**
	* May include non-US virtual key codes
	*/
	export const USVirtualKeyCodes = {
	K_BKSP:8,
	K_TAB:9,
	K_ENTER:13,
	K_SHIFT:16,
	K_CONTROL:17,
	K_ALT:18,
	K_PAUSE:19,
	K_CAPS:20,
	K_ESC:27,
	K_SPACE:32,
	K_PGUP:33,
	K_PGDN:34,
	K_END:35,
	K_HOME:36,
	K_LEFT:37,
	K_UP:38,
	K_RIGHT:39,
	K_DOWN:40,
	K_SEL:41,
	K_PRINT:42,
	K_EXEC:43,
	K_INS:45,
	K_DEL:46,
	K_HELP:47,
	K_0:48,
	K_1:49,
	K_2:50,
	K_3:51,
	K_4:52,
	K_5:53,
	K_6:54,
	K_7:55,
	K_8:56,
	K_9:57,
	K_A:65,
	K_B:66,
	K_C:67,
	K_D:68,
	K_E:69,
	K_F:70,
	K_G:71,
	K_H:72,
	K_I:73,
	K_J:74,
	K_K:75,
	K_L:76,
	K_M:77,
	K_N:78,
	K_O:79,
	K_P:80,
	K_Q:81,
	K_R:82,
	K_S:83,
	K_T:84,
	K_U:85,
	K_V:86,
	K_W:87,
	K_X:88,
	K_Y:89,
	K_Z:90,
	K_NP0:96,
	K_NP1:97,
	K_NP2:98,
	K_NP3:99,
	K_NP4:100,
	K_NP5:101,
	K_NP6:102,
	K_NP7:103,
	K_NP8:104,
	K_NP9:105,
	K_NPSTAR:106,
	K_NPPLUS:107,
	K_SEPARATOR:108,
	K_NPMINUS:109,
	K_NPDOT:110,
	K_NPSLASH:111,
	K_F1:112,
	K_F2:113,
	K_F3:114,
	K_F4:115,
	K_F5:116,
	K_F6:117,
	K_F7:118,
	K_F8:119,
	K_F9:120,
	K_F10:121,
	K_F11:122,
	K_F12:123,
	K_NUMLOCK:144,
	K_SCROLL:145,
	K_LSHIFT:160,
	K_RSHIFT:161,
	K_LCONTROL:162,
	K_RCONTROL:163,
	K_LALT:164,
	K_RALT:165,
	K_COLON:186,
	K_EQUAL:187,
	K_COMMA:188,
	K_HYPHEN:189,
	K_PERIOD:190,
	K_SLASH:191,
	K_BKQUOTE:192,
	K_LBRKT:219,
	/**
	* == K_OEM_5, 0xDC
	*/
	K_BKSLASH:220,
	K_RBRKT:221,
	K_QUOTE:222,
	/**
	* ISO B00, key to right of left shift, not on US keyboard,
	* 0xE2, K_OEM_102
	*/
	K_oE2:226,
	K_OE2:226,
	K_oC1:193, // ISO B11, ABNT-2 key to left of right shift, not on US keyboard
	K_OC1:193,
	'K_?C1':193,
	'k_?C1':193,
	K_oDF:0xDF,
	K_ODF:0xDF,
	/*K_LOPT:50001,
	K_ROPT:50002,
	K_NUMERALS:50003,
	K_SYMBOLS:50004,
	K_CURRENCIES:50005,
	K_UPPER:50006,
	K_LOWER:50007,
	K_ALPHA:50008,
	K_SHIFTED:50009,
	K_ALTGR:50010,
	K_TABBACK:50011,
	K_TABFWD:50012*/
	};

		'K_ALT', // not currently included in isFrameKey
		'K_CTRL', // not currently included in isFrameKey

		@@ -1,4 +1,4 @@
		export { Codes, DeviceSpec, Keyboard, KeyboardProperties, SpacebarText } from '@keymanapp/keyboard-processor';
		export { DeviceSpec, Keyboard, KeyboardProperties, SpacebarText } from '@keymanapp/keyboard-processor';

		@@ -1,9 +1,8 @@
		// TODO: Move to separate folder: 'codes'
		// We should start splitting off code needed by keyboards even without a KeyboardProcessor active.

-// We should start splitting off code needed by keyboards even without a KeyboardProcessor active.
+/*
+ * Keyman is copyright (C) SIL International. MIT License.
+ *
+ * Keyboard key codes and modifier bitmasks.
+ */

		export { default as Codes } from "./text/codes.js";
		export * from "./text/codes.js";

Uh oh!

change(web): move KeyboardProcessor.Codes into common/web/types 🏗️ #11913

change(web): move KeyboardProcessor.Codes into common/web/types 🏗️ #11913

Uh oh!

Conversation

ermshiperete commented Jul 2, 2024

Uh oh!

keymanapp-test-bot bot commented Jul 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User Test Results

Test Artifacts

Uh oh!

mcdurdin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jahorton commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcdurdin commented Jul 31, 2024

Uh oh!

ermshiperete commented Jul 31, 2024

Uh oh!

mcdurdin commented Jul 31, 2024

Uh oh!

ermshiperete commented Aug 1, 2024

Uh oh!

Uh oh!

keymanapp-test-bot bot commented Jul 2, 2024 •

edited

Loading

mcdurdin left a comment •

edited

Loading

jahorton commented Jul 31, 2024 •

edited

Loading