-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): move KeyboardProcessor.Codes into common/web/types #8146
Comments
An extension of this, coming out of the big namespace -> module feature branch that just landed (#8560):
There may be a slight bit of work needed, but I remember noticing how split-friendly the package's organization & contents were while converting KMW to its now-ES-module-based form. |
#8056 made related changes in preparation for this - it was made at the time I identified the potential split and started more actively preparing for it. |
After discussion moving to A18S7 when @mcdurdin is scheduled to be back. |
Also add some trivial unit tests for `Codes` to satisfy coverage threshold. Fixes: #8146
Also add some trivial unit tests for `Codes` to satisfy coverage threshold. Fixes: #8146
Also add some trivial unit tests for `Codes` to satisfy coverage threshold. Fixes: #8146
Also add some trivial unit tests for `Codes` to satisfy coverage threshold. Fixes: #8146
Note that this adds the keyCodes > 50000 to `USVirtualKeyCodes`. Fixes: #8146
I suggest that we move codes.ts into common/web/types as a future refactor.
Originally posted by @mcdurdin in #7809 (comment)
Also,
SystemStoreIDs
from kbdInterface.tsThe text was updated successfully, but these errors were encountered: