-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android,ios): Add ojibwa ifinal/rdot keyboards to FirstVoices #11889
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
eab77b6
chore(oem/fv): Add rdot keyboards to keyboards.csv
darcywong00 a301245
chore(oem/fv): Update other keyboard versions
darcywong00 e29bdf7
fix(oem/firstvoices): Update a-finals keyboard names
darcywong00 59d35ed
Merge remote-tracking branch 'origin/master' into chore/fv/12-11
darcywong00 66eab72
chore(oem/fv): Add fv_ojibwa_ifinal and fv_ojibwa_ifinal_rdot
darcywong00 db0f93a
chore(oem/fv): Update other keyboard versions
darcywong00 b3626c8
Merge remote-tracking branch 'origin/master' into chore/fv/12-11
darcywong00 9a58ffc
fix(oem/fv): Update keyboard versions from fv_all.kmp 12.14
darcywong00 02f80fd
Merge branch 'master' into chore/fv/12-11
darcywong00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HopsAndHops - Can you review eab77b6 and provide guidance what the rdot keyboard names should display as? They're quite long, and I already truncated a little to:
ᐁᓂᔑᓇᐯᒧᐏᓐ (Ojibwa right w-dot)
ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot)
For the rdot keyboards, I used the language information from the .kps files, which differ slightly. Let me know what it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those titles all look okay to me! As a heads up, I do have 2 more variants to the keyboard to be PR'd. I'll think about a shorter title for them and tag you with them when I make those PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would make sense to differentiate the a- and i-finals keyboards like this?:
ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals)
ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot)
ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - could you list those names for me in the following order?
fv_severn_ojibwa
fv_severn_ojibwa_rdot
fv_ojibwa
fv_ojibwa_rdot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are i-finals for an upcoming keyboard PR?
I saw the "Keyboard Details" for
https://keyman.com/keyboards/fv_ojibwa_rdot
mention ᐊᓂᔑᓇᐯᒧᐏᣙ (Ojibwa, i-finals, right w-dot but I don't see that keyboard exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full set of Ojibwa and Oji-Cree syllabics keyboards. fv_ojibwa_ifinal and fv_ojibwa_ifinal_rdot aren't in the repo quite yet, just waiting on a font to be added.:
fv_severn_ojibwa - ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa)
fv_severn_ojibwa_rdot - ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot)
fv_ojibwa - ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals)
fv_ojibwa_rdot - ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot)
fv_ojibwa_ifinal - ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
fv_ojibwa_ifinal_rdot - ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)