Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(android,ios): Add ojibwa ifinal/rdot keyboards to FirstVoices #11889

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Jun 28, 2024

Corresponds to fv_all.kmp updates in keymanapp/keyboards#2866 and keymanapp/keyboards#2900

keyboards.csv changes

@keymanapp-test-bot skip

@darcywong00 darcywong00 added this to the A18S5 milestone Jun 28, 2024
@keymanapp-test-bot
Copy link

User Test Results

Test specification and instructions

User tests are not required

Comment on lines 55 to 58
fv,fv_severn_ojibwa,ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,10.0.1,ojs-Cans,Severn Ojibwa (Unified Canadian Aboriginal Syllabics)
fv,fv_severn_ojibwa_rdot,ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,1.0.1,ojs,Oji-Cree
fv,fv_ojibwa,ᐊᓂᔑᓇᐯᒧᐎᓐ (Ojibwa),Eastern Subarctic,fv_ojibwa_kmw-9.0.js,10.0.1,ojb-Cans,Northwestern Ojibwa (Unified Canadian Aboriginal Syllabics)
fv,fv_ojibwa_rdot,ᐁᓂᔑᓇᐯᒧᐏᓐ (Ojibwa right w-dot),Eastern Subarctic,fv_ojibwa_rdot_kmw-9.0.js,1.0.1,oj,Ojibwa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HopsAndHops - Can you review eab77b6 and provide guidance what the rdot keyboard names should display as? They're quite long, and I already truncated a little to:
ᐁᓂᔑᓇᐯᒧᐏᓐ (Ojibwa right w-dot)
ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot)

For the rdot keyboards, I used the language information from the .kps files, which differ slightly. Let me know what it should be.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those titles all look okay to me! As a heads up, I do have 2 more variants to the keyboard to be PR'd. I'll think about a shorter title for them and tag you with them when I make those PRs.

Copy link

@HopsAndHops HopsAndHops Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would make sense to differentiate the a- and i-finals keyboards like this?:

ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals)
ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot)
ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - could you list those names for me in the following order?

fv_severn_ojibwa
fv_severn_ojibwa_rdot
fv_ojibwa
fv_ojibwa_rdot

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it would make sense to differentiate the a- and i-finals keyboards like this?:

ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)

Are i-finals for an upcoming keyboard PR?

I saw the "Keyboard Details" for
https://keyman.com/keyboards/fv_ojibwa_rdot

mention ᐊᓂᔑᓇᐯᒧᐏᣙ (Ojibwa, i-finals, right w-dot but I don't see that keyboard exists.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full set of Ojibwa and Oji-Cree syllabics keyboards. fv_ojibwa_ifinal and fv_ojibwa_ifinal_rdot aren't in the repo quite yet, just waiting on a font to be added.:

fv_severn_ojibwa - ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa)
fv_severn_ojibwa_rdot - ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot)
fv_ojibwa - ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals)
fv_ojibwa_rdot - ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot)
fv_ojibwa_ifinal - ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
fv_ojibwa_ifinal_rdot - ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)

@darcywong00 darcywong00 changed the title chore(android,ios): Add rdot keyboards to FirstVoices chore(android,ios): Add ojibwa ifinal/rdot keyboards to FirstVoices Jul 6, 2024
Comment on lines +55 to +60
fv,fv_severn_ojibwa,ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,10.0.1,ojs-Cans,Severn Ojibwa (Unified Canadian Aboriginal Syllabics)
fv,fv_severn_ojibwa_rdot,ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,1.0.1,ojs,Oji-Cree
fv,fv_ojibwa,ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals),Eastern Subarctic,fv_ojibwa_kmw-9.0.js,10.0.1,ojb-Cans,Northwestern Ojibwa (Unified Canadian Aboriginal Syllabics)
fv,fv_ojibwa_rdot,ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot),Eastern Subarctic,fv_ojibwa_rdot_kmw-9.0.js,1.0.1,oj,Ojibwa
fv,fv_ojibwa_ifinal,ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals),Eastern Subarctic,fv_ojibwa_ifinal_kmw-9.0.js,1.0,oj,Ojibwa
fv,fv_ojibwa_ifinal_rdot,ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals right w-dot),Eastern Subarctic,fv_ojibwa_ifinal_rdot_kmw-9.0.js,1.0,oj,Ojibwa
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope I correctly copied the keyboard names from @HopsAndHops
#11889 (comment)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants