-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(android,ios): Add ojibwa ifinal/rdot keyboards to FirstVoices #11889
base: master
Are you sure you want to change the base?
Conversation
User Test ResultsTest specification and instructions User tests are not required |
oem/firstvoices/keyboards.csv
Outdated
fv,fv_severn_ojibwa,ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,10.0.1,ojs-Cans,Severn Ojibwa (Unified Canadian Aboriginal Syllabics) | ||
fv,fv_severn_ojibwa_rdot,ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,1.0.1,ojs,Oji-Cree | ||
fv,fv_ojibwa,ᐊᓂᔑᓇᐯᒧᐎᓐ (Ojibwa),Eastern Subarctic,fv_ojibwa_kmw-9.0.js,10.0.1,ojb-Cans,Northwestern Ojibwa (Unified Canadian Aboriginal Syllabics) | ||
fv,fv_ojibwa_rdot,ᐁᓂᔑᓇᐯᒧᐏᓐ (Ojibwa right w-dot),Eastern Subarctic,fv_ojibwa_rdot_kmw-9.0.js,1.0.1,oj,Ojibwa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HopsAndHops - Can you review eab77b6 and provide guidance what the rdot keyboard names should display as? They're quite long, and I already truncated a little to:
ᐁᓂᔑᓇᐯᒧᐏᓐ (Ojibwa right w-dot)
ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot)
For the rdot keyboards, I used the language information from the .kps files, which differ slightly. Let me know what it should be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those titles all look okay to me! As a heads up, I do have 2 more variants to the keyboard to be PR'd. I'll think about a shorter title for them and tag you with them when I make those PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would make sense to differentiate the a- and i-finals keyboards like this?:
ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals)
ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot)
ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep - could you list those names for me in the following order?
fv_severn_ojibwa
fv_severn_ojibwa_rdot
fv_ojibwa
fv_ojibwa_rdot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it would make sense to differentiate the a- and i-finals keyboards like this?:
ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)
Are i-finals for an upcoming keyboard PR?
I saw the "Keyboard Details" for
https://keyman.com/keyboards/fv_ojibwa_rdot
mention ᐊᓂᔑᓇᐯᒧᐏᣙ (Ojibwa, i-finals, right w-dot but I don't see that keyboard exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full set of Ojibwa and Oji-Cree syllabics keyboards. fv_ojibwa_ifinal and fv_ojibwa_ifinal_rdot aren't in the repo quite yet, just waiting on a font to be added.:
fv_severn_ojibwa - ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa)
fv_severn_ojibwa_rdot - ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot)
fv_ojibwa - ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals)
fv_ojibwa_rdot - ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot)
fv_ojibwa_ifinal - ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals)
fv_ojibwa_ifinal_rdot - ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals, right w-dot)
Names per @HopsAndHops suggestion
fv,fv_severn_ojibwa,ᐊᓂᔑᓂᓂᒧᐎᐣ (Severn Ojibwa),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,10.0.1,ojs-Cans,Severn Ojibwa (Unified Canadian Aboriginal Syllabics) | ||
fv,fv_severn_ojibwa_rdot,ᐊᓂᔑᓂᓂᒧᐏᐣ (Severn Ojibwa right w-dot),Eastern Subarctic,fv_severn_ojibwa_kmw-9.0.js,1.0.1,ojs,Oji-Cree | ||
fv,fv_ojibwa,ᐊᓂᔑᓇᐯᒧᐎᓐ (a-finals),Eastern Subarctic,fv_ojibwa_kmw-9.0.js,10.0.1,ojb-Cans,Northwestern Ojibwa (Unified Canadian Aboriginal Syllabics) | ||
fv,fv_ojibwa_rdot,ᐁᓂᔑᓇᐯᒧᐏᓐ (a-finals right w-dot),Eastern Subarctic,fv_ojibwa_rdot_kmw-9.0.js,1.0.1,oj,Ojibwa | ||
fv,fv_ojibwa_ifinal,ᐊᓂᔑᓇᐯᒧᐎᣙ (i-finals),Eastern Subarctic,fv_ojibwa_ifinal_kmw-9.0.js,1.0,oj,Ojibwa | ||
fv,fv_ojibwa_ifinal_rdot,ᐊᓂᔑᓇᐯᒧᐏᣙ (i-finals right w-dot),Eastern Subarctic,fv_ojibwa_ifinal_rdot_kmw-9.0.js,1.0,oj,Ojibwa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope I correctly copied the keyboard names from @HopsAndHops
#11889 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Corresponds to fv_all.kmp updates in keymanapp/keyboards#2866 and keymanapp/keyboards#2900
keyboards.csv changes
@keymanapp-test-bot skip