feat(linux): comments for mc_kmxfile 🐘 #11879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required |
ermshiperete
requested changes
Jun 26, 2024
SabineSIL
changed the title
…ther_files feat(linux): comments on several other files 🐘
SabineSIL
commented
Jul 1, 2024
…x/mcompile-rework_mcompile
…compile feat(linux): comments on module mcompile and filesystem 🐘
…eymap_part2 feat(linux): comments for rework keymap (second PR)🐘
feat(linux): comments on module u16 🐘
SabineSIL
merged commit 94e2bb1
into
origin/feat/linux/mcompile-rework_keymap
6 of 9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes parts of PR #9384.
Some comments have been moved into an issue #11802
This PR addresses and bundles comments made on #9384 for the module mc_kmxfile.
@keymanapp-test-bot skip