-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux): mnemonic layout support 🐘 #9384
Open
SabineSIL
wants to merge
291
commits into
epic/linux-mcompile
Choose a base branch
from
feat/linux/mcompile-DoConvert-read
base: epic/linux-mcompile
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(linux): mnemonic layout support 🐘 #9384
SabineSIL
wants to merge
291
commits into
epic/linux-mcompile
from
feat/linux/mcompile-DoConvert-read
+3,570
−2,361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…romVK; return correct char
…vert-read' into feature-linux-mcompile-DoConvert-read
…ector of std::string)
…BOOL/bool to int/KMX_DWORD
User Test ResultsTest specification and instructions User tests are not required |
…x/mcompile-rework_mcompile
…compile feat(linux): comments on module mcompile and filesystem 🐘
…eymap_part2 feat(linux): comments for rework keymap (second PR)🐘
feat(linux): comments on module u16 🐘
…mpile-rework_mc_kmxfile # Conflicts: # linux/mcompile/keymap/mc_import_rules.cpp
…c_kmxfile Feat/linux/mcompile merge mcompile-rework_mc_kmxfile into mcompile-DoConvert-read 🐘
ermshiperete
approved these changes
Jul 25, 2024
You'll have to update the branch (aka merge master) to get a successful build. CI build related things have changed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7068
see #3345
This is a proposal to rewrite mcompile for Linux. For this we need to query the base keyboard data from the Linux platform, then rewriting the keyboard .kmx using the same approach as is done in mcompile for Windows, but working from the data from the x11 keyboard on Linux.
Ideally, we'd rewrite mcompile to be cross-platform (Windows, Linux, macOS), so that the keyboard interrogation would be separated from the .kmx rewriting, at least to some degree. Nevertheless it would probably be easiest to start from a standalone implementation.
connected to #8558 mcompile - use static tables for windows keyboard data
@keymanapp-test-bot skip