Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cosmiconfig, update deps #124

Closed
wants to merge 3 commits into from

Conversation

jednano
Copy link

@jednano jednano commented Jul 25, 2019

Uses smart defaults based on conventional expectations in the JS ecosystem

Deprecated

  1. Use .graphqlrc or other cosmiconfig variations instead of .graphqlconfig[.y[a]ml].

Breaking Changes

  1. getGraphQLConfig is now async.
  2. findGraphQLConfigFile has been removed.

Related: https://github.com/prisma/vscode-graphql/issues/54

fix graphql/vscode-graphql#119
fix graphql/vscode-graphql#116
fix graphql/vscode-graphql#115
fix graphql/graphiql#2354
fix graphql/vscode-graphql#109
fix graphql/vscode-graphql#108
fix graphql/vscode-graphql#107
fix graphql/vscode-graphql#99
fix graphql/vscode-graphql#98
fix graphql/vscode-graphql#95
fix graphql/vscode-graphql#93
fix graphql/graphiql#2333
fix graphql/vscode-graphql#89

@jednano jednano force-pushed the cosmiconfig branch 4 times, most recently from 1cea2f6 to c2bf85b Compare July 25, 2019 19:30
@jednano jednano force-pushed the cosmiconfig branch 4 times, most recently from 86c455b to 7a4768b Compare July 25, 2019 20:16
uses smart defaults based on conventional expectations in the JS ecosystem

DEPRECATED:
- Use .graphqlrc or other cosmiconfig variations instead of .graphqlconfig[.y[a]ml].

BREAKING CHANGES:
- getGraphQLConfig is now async.
- findGraphQLConfigFile has been removed.

fix kamilkisiela#119
fix kamilkisiela#116
fix kamilkisiela#115
fix kamilkisiela#110
fix kamilkisiela#109
fix kamilkisiela#108
fix kamilkisiela#107
fix kamilkisiela#99
fix kamilkisiela#98
fix kamilkisiela#95
fix kamilkisiela#93
fix kamilkisiela#92
fix kamilkisiela#89
README.md Outdated Show resolved Hide resolved
@jednano
Copy link
Author

jednano commented Jul 26, 2019

This is going to fail until ardatan/graphql-import#350 is merged/published.

@rychkog
Copy link

rychkog commented Aug 1, 2019

Any progress on this? Cause the extension is unusable without this fix :(

@kamilkisiela
Copy link
Owner

Hi there :) We're working on a new version of GraphQL Config. The goal is to make it platform agnostic, flexible enough to use with any tool and framework, reduce the bundle size and a lot more and what's even more important, bring it back to life and keep maintaining.

New changes graphql/vscode-graphql#162 are already merged into master and v3.0.0-alpha.13 is released.

We decided to use cosmiconfig just like in other libraries we maintain, exactly like you did here.

Thanks for your contribution! The project was pretty much dead but now we have plans for it and we will maintain the repo, so no more inactive PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment