Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the file to be named .graphqlconfig.json #119

Closed
pothos-dev opened this issue May 3, 2019 · 3 comments
Closed

Allow the file to be named .graphqlconfig.json #119

pothos-dev opened this issue May 3, 2019 · 3 comments

Comments

@pothos-dev
Copy link

pothos-dev commented May 3, 2019 •
edited
Loading

Howdy,
I'm working on tools in the GraphQL ecosystem and like the idea to have a unified configuration file that can be shared by many tools.

Unfortunately, I find the editing experience of the .graphqlconfig file to be a bit unpleasant at the moment.

Issue #52 tracks the idea to provide a JSON schema to allow editors to autocomplete code, which would help a bit. In addition, I want to make the case for allowing the config file to be named .graphqlconfig.json:

  • It would immediately improve the editing experience in most code editors, checking for syntax errors, highlighting code and providing auto-formatting, without needing to install another extension.
  • It is the obvious companion to the already allowed .graphqlconfig.yaml
  • It would bring home the message that the file format is, in fact, JSON.
  • Existing .graphqlconfig files would of course still be supported.

It is not clear to me if there is any reason why using the json extension for the config file would not be allowed, but I was also unable to find any previous discussion on the issue.
@pothos-dev pothos-dev changed the title Allow the file to be named graphqlconfig.json Allow the file to be named .graphqlconfig.json May 3, 2019
@divyenduz divyenduz mentioned this issue Jul 11, 2019
Closed
@jednano
Copy link

jednano commented Jul 25, 2019

Use cosmiconfig to achieve this goal easily.

jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig
48d32b9 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: getGraphQLConfig is now async, findGraphQLConfigFile is removed

fix kamilkisiela#119
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
eb5d490 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: getGraphQLConfig is now async, findGraphQLConfigFile is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, fix kamilkisiela#107, fix kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
@jednano jednano mentioned this issue Jul 25, 2019
Closed
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
f803fff 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: getGraphQLConfig is now async, findGraphQLConfigFile is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, fix kamilkisiela#107, fix kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
2ce1b0d 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: .graphqlconfig -> .graphqlrc, getGraphQLConfig is now async, findGraphQLConfigFile
is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, fix kamilkisiela#107, fix kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
1cea2f6 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: .graphqlconfig -> .graphqlrc, getGraphQLConfig is now async, findGraphQLConfigFile
is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, kamilkisiela#107, kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
c2bf85b 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: .graphqlconfig -> .graphqlrc, getGraphQLConfig is now async, findGraphQLConfigFile
is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, kamilkisiela#107, kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
@jednano
Copy link

jednano commented Jul 25, 2019

Fixed this in #124. Please merge!

jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
04d2c36 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: .graphqlconfig -> .graphqlrc, getGraphQLConfig is now async, findGraphQLConfigFile
is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, kamilkisiela#107, kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
4774c07 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: .graphqlconfig -> .graphqlrc, getGraphQLConfig is now async, findGraphQLConfigFile
is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, kamilkisiela#107, kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
86c455b 
uses smart defaults based on conventional expectations in the JS ecosystem

BREAKING CHANGE: .graphqlconfig -> .graphqlrc, getGraphQLConfig is now async, findGraphQLConfigFile
is removed

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, kamilkisiela#107, kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
7a4768b 
uses smart defaults based on conventional expectations in the JS ecosystem

DEPRECATED:
- Use .graphqlrc or other cosmiconfig variations instead of .graphqlconfig[.y[a]ml].

BREAKING CHANGES:
- getGraphQLConfig is now async.
- findGraphQLConfigFile has been removed.

fix kamilkisiela#119, kamilkisiela#116, kamilkisiela#115, kamilkisiela#110, kamilkisiela#109, kamilkisiela#108, kamilkisiela#107, kamilkisiela#99, kamilkisiela#98, kamilkisiela#95, kamilkisiela#93, kamilkisiela#92, kamilkisiela#89
jednano added a commit to jednano/graphql-config that referenced this issue Jul 25, 2019
@jednano
feat: use cosmiconfig, update deps
7a1f3d5 
uses smart defaults based on conventional expectations in the JS ecosystem

DEPRECATED:
- Use .graphqlrc or other cosmiconfig variations instead of .graphqlconfig[.y[a]ml].

BREAKING CHANGES:
- getGraphQLConfig is now async.
- findGraphQLConfigFile has been removed.

fix kamilkisiela#119
fix kamilkisiela#116
fix kamilkisiela#115
fix kamilkisiela#110
fix kamilkisiela#109
fix kamilkisiela#108
fix kamilkisiela#107
fix kamilkisiela#99
fix kamilkisiela#98
fix kamilkisiela#95
fix kamilkisiela#93
fix kamilkisiela#92
fix kamilkisiela#89
@kamilkisiela kamilkisiela mentioned this issue Oct 16, 2019
Merged
23 tasks
@kamilkisiela
Copy link
Owner

Hi there :) We're working on a new version of GraphQL Config. The goal is to make it platform agnostic, flexible enough to use with any tool and framework, reduce the bundle size and a lot more and what's even more important, bring it back to life and keep maintaining.

New changes #162 are already merged into master and v3.0.0-alpha.13 is released.

We decided to use cosmiconfig just like in other libraries we maintain, just like @jedmao did so now you're able to use yaml, json and even js files, here you can read more.

@kamilkisiela kamilkisiela added this to the v3.0.0 milestone Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jednano @kamilkisiela @pothos-dev