Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9972): floating player #1

Merged
merged 20 commits into from
Jun 17, 2020
Merged

feat(FEC-9972): floating player #1

merged 20 commits into from
Jun 17, 2020

Commits on May 31, 2020

  1. feat(FEC-9972): floating player

    @RoyBregman
    RoyBregman committed May 31, 2020
    Configuration menu
    Copy the full SHA
    514896f View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2020

  1. phase 1

    @RoyBregman
    RoyBregman committed Jun 7, 2020
    Configuration menu
    Copy the full SHA
    8a5a3b4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. flow fixes, changing configuration struct, updating travis

    @RoyBregman
    RoyBregman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    93a5c3e View commit details
    Browse the repository at this point in the history

  2. Create pull_request_template.md 

     docs: added pull request template
    @RoyBregman
    RoyBregman authored Jun 8, 2020
    Configuration menu
    Copy the full SHA
    a71a2b1 View commit details
    Browse the repository at this point in the history

  3. added tests setup

    @RoyBregman
    RoyBregman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    33dd50e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'FEC-9972-floating-player' of https://github.com/kaltura… 

    …/playkit-js-visibility into FEC-9972-floating-player
    @RoyBregman
    RoyBregman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    91ca289 View commit details
    Browse the repository at this point in the history

  5. Added "solves" to template

    @RoyBregman
    RoyBregman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    b81a67e View commit details
    Browse the repository at this point in the history

  6. code review

    @RoyBregman
    RoyBregman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    9b2a80c View commit details
    Browse the repository at this point in the history

  7. pull request template fix

    @RoyBregman
    RoyBregman committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    6688c1f View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. remove listeners on destroy

    @RoyBregman
    RoyBregman committed Jun 9, 2020
    Configuration menu
    Copy the full SHA
    7ced731 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. code review

    @RoyBregman
    RoyBregman committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    0c01576 View commit details
    Browse the repository at this point in the history

  2. moving const to top

    @RoyBregman
    RoyBregman committed Jun 14, 2020
    Configuration menu
    Copy the full SHA
    b998db0 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. small fix

    @RoyBregman
    RoyBregman committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    d7d1bd0 View commit details
    Browse the repository at this point in the history

  2. changes due to the studio

    @RoyBregman
    RoyBregman committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e46debd View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. removed px from config, changed threshold to be 0-100 like in studio,… 

    … made a better destroy handle
    @RoyBregman
    RoyBregman committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    44fda19 View commit details
    Browse the repository at this point in the history

  2. last code review fixed + added PIP functionality

    @RoyBregman
    RoyBregman committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    97cf72e View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. added unit testing empty spec file

    @RoyBregman
    RoyBregman committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    66e09de View commit details
    Browse the repository at this point in the history

  2. fix travis build fail

    @RoyBregman
    RoyBregman committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8ddb0c1 View commit details
    Browse the repository at this point in the history

  3. fix karma run

    @RoyBregman
    RoyBregman committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    29681a2 View commit details
    Browse the repository at this point in the history

  4. adding dummy test for now so unit tests will now fail

    @RoyBregman
    RoyBregman committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    b2411a7 View commit details
    Browse the repository at this point in the history