feat(FEC-9972): floating player #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: added pull request template
OrenMe
suggested changes
Jun 8, 2020
OrenMe
suggested changes
Jun 8, 2020
| The configuration uses the following structure: | ||
|
|
||
| ```js | ||
| { |
| ``` | ||
|
|
||
| #### Default Configuration Values | ||
| ```js |
There was a problem hiding this comment.
I didn't do any documentation yet. Will complete this in the next phase
Yuvalke
suggested changes
Jun 8, 2020
OrenMe
reviewed
Jun 8, 2020
Yuvalke
suggested changes
Jun 8, 2020
Yuvalke
suggested changes
Jun 8, 2020
yairans
suggested changes
Jun 8, 2020
Yuvalke
suggested changes
Jun 14, 2020
OrenMe
approved these changes
Jun 15, 2020
… made a better destroy handle
Yuvalke
suggested changes
Jun 16, 2020
yairans
previously requested changes
Jun 16, 2020
Yuvalke
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
New floating player feature - adding new plugin to support visibility handling.
CheckLists
solves FEC-9972