support ghc-9.10 #1367
support ghc-9.10 #1367
Conversation
larskuhtz
force-pushed
the
lars/ghc-9.10
branch
2 times, most recently
from
a561a2d
to
d12f3c2
Compare
|
Nix builds are failing with a somewhat cryptic message. Maybe the new version of pact-time on Hackage needs some time to propagate to nix? Cabal builds are green. |
|
|
||
|
|
||
| -- | | ||
| -- Module: unsafe.Data.Foldable.Unsafe |
There was a problem hiding this comment.
| -- Module: unsafe.Data.Foldable.Unsafe | |
| -- Module: Data.Foldable.Unsafe |
| -- This is to avoid cluttering production code with | ||
| -- `{-# OPTIONS_GHC -Wno-x-partial #-}` pragmas with base >= 4.20 |
There was a problem hiding this comment.
Why not disable it package-wide?
There was a problem hiding this comment.
I think that it's generally good to keep the scope of disabled warnings narrow. If it was possible to scope it to an individual functions, I would have preferred that -- in that case this library would probably not be necessary, because one could annotate each use case in the original code.
| os: ['ubuntu-20.04', 'ubuntu-22.04', 'macos-latest', 'macos-14'] | ||
| ghc: ['9.6.6', '9.8.2', '9.10.1'] | ||
| cabal: ['3.12'] | ||
| os: ['ubuntu-20.04', 'ubuntu-22.04', 'macos-14'] | ||
| cabalcache: ['true'] | ||
| flags: ['+build-tool'] |
There was a problem hiding this comment.
The build with +build-tool still has a bunch of -Wx-partial warnings.
There was a problem hiding this comment.
@edmundnoble sorry, I missed your comments when I hit the merge button (from the GitHub phone app). I'll address your comments in a follow up PR.
Build system and CI:
Maintenance of dependencies:
Compiler warnings and deprecations:
{-# OPTIONS_GHC -fno-warn-x-partial #-}pragmas with GHC >=9.10.foldl'is now inPreludeand uses ofheadandtailcausex-partialwarning)