support ghc-9.10 #1976
support ghc-9.10 #1976
Conversation
| qtext = "SELECT blockheight, hash FROM BlockHistory \ | ||
| \ ORDER BY blockheight ASC LIMIT 1" | ||
| qtext = "SELECT blockheight, hash FROM BlockHistory ORDER BY blockheight ASC LIMIT 1" |
There was a problem hiding this comment.
String literals with gaps break CPP. It's probably generally a good idea to avoid them and wait for new multi-line string literals to become available in GHC (https://github.com/ghc-proposals/ghc-proposals/blob/master/proposals/0569-multiline-strings.rst).
src/Numeric/Additive.hs
Outdated
There was a problem hiding this comment.
This file (and also 'Numeric.AffineSpace') are now available in pact-time:numeric >=0.3.0.0.
larskuhtz
force-pushed
the
lars/ghc-9.10
branch
2 times, most recently
from
8d96b23
to
fef001a
Compare
larskuhtz
force-pushed
the
lars/ghc-9.10
branch
5 times, most recently
from
33bd712
to
c6b6d19
Compare
| "ghc": ["9.6.5", "9.8.1"], | ||
| "cabal": ["3.10"], | ||
| "ghc": ["9.6.5", "9.8.2", "9.10.1"], | ||
| "cabal": ["3.12"], | ||
| "os": ["ubuntu-20.04", "ubuntu-22.04"], | ||
| "use-freeze-file": ["false"] | ||
| "use-freeze-file": ["false"], | ||
| "include" : [ | ||
| { | ||
| "ghc": "9.6.5", | ||
| "cabal": "3.12", | ||
| "os": "ubuntu-22.04", | ||
| "use-freeze-file": "true" | ||
| } | ||
| ] | ||
| } | ||
| EOF | ||
| )" | ||
| else | ||
| MATRIX="$(jq -c '.' <<EOF | ||
| { | ||
| "ghc": ["9.6.5"], | ||
| "cabal": ["3.10"], | ||
| "os": ["ubuntu-20.04", "ubuntu-22.04"], | ||
| "use-freeze-file": ["true"] | ||
| "ghc": ["9.6.5", "9.8.2", "9.10.1"], | ||
| "cabal": ["3.12"], | ||
| "os": ["ubuntu-22.04"], | ||
| "use-freeze-file": ["false"], | ||
| "include" : [ | ||
| { | ||
| "ghc": "9.6.5", | ||
| "cabal": "3.12", | ||
| "os": "ubuntu-22.04", | ||
| "use-freeze-file": "true" | ||
| } | ||
| ] |
There was a problem hiding this comment.
The first block here is specifically for scheduled builds, and the second is for the ones that happen on every PR. Right now we only do unfrozen builds on the schedule, and frozen builds on every PR.
There was a problem hiding this comment.
But why? Build times are not affected by the number of builds. They are in parallel and dependencies are fully cached.
Why not give feedback early?
There was a problem hiding this comment.
The problem with scheduled builds is that, as long as there is no process to check those regularly and respond to issues -- nobody will ever care to fix them.
There was a problem hiding this comment.
I'm fine with disabling the scheduled logic here and putting unfrozen builds into the matrix here.
base >=4.20fold'is exported inPrelude.headandtailvia the newx-partialwarning. In Pact this addressedthrough the addition of an internal library that provides "unsafe" versions of partial functions that do not
trigger the warning. If we use partial functions in chainweb we can import them from there.
Numeric.AdditiveandNumeric.AffineSpaceand import these frompact-time:numeric >=0.3.0.1pact-timenow provides those modules through an internal public library.