Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ghc-9.10 #1976

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2440447
format cabal file more consistently
larskuhtz Jun 30, 2024
313e144
remove redundant upper bound on unliftio
larskuhtz Jun 30, 2024
d3f3343
raise lower bound on unordered containers
larskuhtz Jun 30, 2024
bc4842d
add missing other-modules in cabal file
larskuhtz Jun 30, 2024
4d5533a
fix upper bound of crypton-connection
larskuhtz Jun 30, 2024
5085709
raise lower bound on crypton-connection to 0.4
larskuhtz Jun 30, 2024
4f944e8
Merge branch 'master' into lars/update/crypton-connection
larskuhtz Jun 30, 2024
e484dd0
update freeze file
larskuhtz Jun 30, 2024
aa9e0c9
support ghc-9.10
larskuhtz Jun 30, 2024
001ab16
Merge branch 'lars/ghc-9.10' into lars/update/crypton-connection
larskuhtz Jul 1, 2024
be331ae
support ghc-9.10
larskuhtz Jun 30, 2024
3fec737
update freeze file
larskuhtz Jul 2, 2024
4fbb05e
remove redundant upper bound on mwc-probability
larskuhtz Jul 2, 2024
eae82ba
update cabal CI workflows
larskuhtz Jul 2, 2024
68b871a
update pact pin
larskuhtz Jul 4, 2024
bc6a19c
update nix hackage
larskuhtz Jul 4, 2024
e643eaf
Merge branch 'lars/update/crypton-connection' into lars/ghc-9.10
larskuhtz Jul 4, 2024
d5b8dde
deprecate rosetta
larskuhtz Jul 31, 2024
fdb5ac9
Merge branch 'lars/deprecate-rosetta' into lars/ghc-9.10
larskuhtz Jul 31, 2024
72c2868
update ethereum pin and hashes package
larskuhtz Jul 31, 2024
38163d3
fix flaky tests
larskuhtz Jul 31, 2024
f5e2acd
update freeze file
larskuhtz Jul 31, 2024
359c8e6
update pact pin to latest master
larskuhtz Jul 31, 2024
affee0c
update nix flake lock
larskuhtz Jul 31, 2024
31c108e
Merge branch 'master' into lars/ghc-9.10
larskuhtz Jul 31, 2024
217ed8f
Merge branch 'master' into lars/ghc-9.10
larskuhtz Aug 7, 2024
5dae0b6
allow-newer for hashable
larskuhtz Aug 8, 2024
3ef8af2
Merge branch 'master' into lars/ghc-9.10
larskuhtz Aug 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 32 additions & 11 deletions .github/workflows/applications.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,21 +134,36 @@ jobs:
if "${{ github.event_name == 'schedule' }}" == "true"; then
MATRIX="$(jq -c '.' <<EOF
{
"ghc": ["9.6.5", "9.8.1"],
"cabal": ["3.10"],
"ghc": ["9.6.5", "9.8.2", "9.10.1"],
"cabal": ["3.12"],
"os": ["ubuntu-20.04", "ubuntu-22.04"],
"use-freeze-file": ["false"]
"use-freeze-file": ["false"],
"include" : [
{
"ghc": "9.6.5",
"cabal": "3.12",
"os": "ubuntu-22.04",
"use-freeze-file": "true"
}
]
}
EOF
)"
else
MATRIX="$(jq -c '.' <<EOF
{
"ghc": ["9.6.5"],
"cabal": ["3.10"],
"os": ["ubuntu-20.04", "ubuntu-22.04"],
"use-freeze-file": ["true"]
"ghc": ["9.6.5", "9.8.2", "9.10.1"],
"cabal": ["3.12"],
"os": ["ubuntu-22.04"],
"use-freeze-file": ["false"],
"include" : [
{
"ghc": "9.6.5",
"cabal": "3.12",
"os": "ubuntu-22.04",
"use-freeze-file": "true"
}
]
Comment on lines -137 to +166
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first block here is specifically for scheduled builds, and the second is for the ones that happen on every PR. Right now we only do unfrozen builds on the schedule, and frozen builds on every PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why? Build times are not affected by the number of builds. They are in parallel and dependencies are fully cached.

Why not give feedback early?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with scheduled builds is that, as long as there is no process to check those regularly and respond to issues -- nobody will ever care to fix them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with disabling the scheduled logic here and putting unfrozen builds into the matrix here.

}
EOF
)"
Expand Down Expand Up @@ -235,12 +250,16 @@ jobs:
if: startsWith(matrix.os, 'ubuntu-')
run: sudo chown -R $USER /usr/local/.ghcup
- name: Install GHC and Cabal
id: setup
uses: haskell-actions/setup@v2
with:
ghc-version: ${{ matrix.ghc }}
cabal-version: ${{ matrix.cabal }}
- name: Confirm GHC and Cabal installation
run: |
echo "setup ghc-version: ${{ steps.setup.outputs.ghc-version }}"
echo "setup cabal-version: ${{ steps.setup.outputs.cabal-version }}"
echo "setup cabal-store: ${{ steps.setup.outputs.cabal-store }}"
ghc --version
cabal --version
- name: Install non-Haskell dependencies (ubuntu)
Expand Down Expand Up @@ -326,11 +345,12 @@ jobs:
diff -w <(git show HEAD:cabal.project.freeze) cabal.project.freeze || true
- name: Sync from cabal cache
if: env.USE_CABAL_CACHE == 'true'
uses: larskuhtz/cabal-cache-action@a0f263d898dd246217960262caa1d381cf066e9a
uses: larskuhtz/cabal-cache-action@4b537195b33898fcd9adc62cee2a44986fd7b1b6
with:
bucket: "kadena-cabal-cache"
region: "us-east-1"
folder: "${{ matrix.os }}-${{ matrix.ghc }}-${{ matrix.use-freeze-file }}"
folder: "packages/${{ matrix.os }}"
store_path: ${{ steps.setup.outputs.cabal-store }}
aws_access_key_id: "${{ secrets.kadena_cabal_cache_aws_access_key_id }}"
aws_secret_access_key: "${{ secrets.kadena_cabal_cache_aws_secret_access_key }}"
edmundnoble marked this conversation as resolved.
Show resolved Hide resolved
- name: Install build dependencies
Expand Down Expand Up @@ -629,7 +649,7 @@ jobs:
# different tags
include:
- ghc: "9.6.5"
os: "ubuntu-20.04"
edmundnoble marked this conversation as resolved.
Show resolved Hide resolved
os: "ubuntu-22.04"
use-freeze-file: "true"
env:
OS: ${{ matrix.os }}
Expand All @@ -647,6 +667,7 @@ jobs:
run: |
tar -xzf "$ARTIFACTS_ARCHIVE"

# ubuntu-22.04 only include libssl3. ubuntu-20.04 uses libssl1.1
- name: Create Dockerfile
run: |
cat > Dockerfile <<DEOF
Expand All @@ -664,7 +685,7 @@ jobs:
apt-get install -y \
ca-certificates \
libgmp10 \
libssl1.1 \
libssl3 \
libsnappy1v5 \
zlib1g \
liblz4-1 \
Expand Down
30 changes: 15 additions & 15 deletions cabal.project
Original file line number Diff line number Diff line change
Expand Up @@ -103,10 +103,10 @@ source-repository-package
--sha256: 19pjy06xrx2siggzybcmly0qaq4ds3yzxcsvqwgs4qh9kkzh0kqh

source-repository-package
type: git
location: https://github.com/kadena-io/kadena-ethereum-bridge.git
tag: 3837c4c81f1beaffc1d52375e61576366d49170a
--sha256: 1knhscph2g3saz0pjd1d5a32mr281msapccfrillgd2qk4pj7xjc
type: git
location: https://github.com/kadena-io/kadena-ethereum-bridge.git
tag: 3837c4c81f1beaffc1d52375e61576366d49170a
--sha256: 1knhscph2g3saz0pjd1d5a32mr281msapccfrillgd2qk4pj7xjc

source-repository-package
type: git
Expand All @@ -123,19 +123,20 @@ source-repository-package
tag: d8019c3404d6f3b3c0b0416e9899cfdf614ef425
--sha256: 09msayidg23rsdz97fcfqqalm4pbawx3c1qihgab8hnlmjxby103

-- Patch merged into master (upcoming version 10.0). We are currently using 9.2
-- Patch merged into master (upcoming verison 10.0). We are currently using 9.2.
-- This fork contains additional fixes for using 9.2 with recent compilers.
source-repository-package
type: git
location: https://github.com/larskuhtz/sbv
tag: b66e3a04c20f753213fe7e5115a95b3fe34109f9
--sha256: 0dca5pl56nz8ijnqavnpxw5f47qmpalszd5w0ag8bq3fd0l3839m
tag: 1f2d042718fcf9a140398bd3dedac77c207cce27
--sha256: 0l3nhsdxsyx17i29dw691d6bbqz26af6lg6pi1c2kb34v59m2rk3

-- Required for non-canonical decode in base64-bytestring (remove after 2.20 fork)
source-repository-package
type: git
location: https://github.com/emilypi/base64-bytestring-kadena
tag: 174af3523616c8fe01449da5ccbb9f16df097ac3
--sha256: sha256-kVFIy+Aj3TNJpsM1Cs/5uGmzeWwHKYWjjCQ+L1/XOj8=
--sha256: 0grssxgjygi4ijiqaa87diwv6sdqz77hldf3lr4k7p93w35lhlci

-- -------------------------------------------------------------------------- --
-- Relaxed Bounds
Expand Down Expand Up @@ -196,12 +197,11 @@ allow-newer: regex-base:*
allow-newer: regex-tdfa:*
allow-newer: base-compat-batteries:*

-- -------------------------------------------------------------------------- --
-- Upper Bounds
-- webauthn also uses overly restrictive upper bounds
allow-newer: webauthn:*

allow-newer: webauthn:these
allow-newer: webauthn:time
allow-newer: webauthn:aeson
-- many packages use an spurious <1.5 upper bound on hashable
allow-newer: *:hashable

-- Hashable 1.4.5 changes the hashing of bytestring, which causes some issues.
constraints: hashable < 1.4.5
-- -------------------------------------------------------------------------- --
-- Upper Bounds
Loading
Loading