Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump spegel #9599

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Bump spegel #9599

merged 4 commits into from
Mar 4, 2024

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 29, 2024

Proposed Changes

based on changes from #9365

  • Bump spegel to v0.0.18-k3s3
    • Adds wildcard registry support
    • Fixes issue with excessive CPU utilization while waiting for containerd to start
  • Add env var to allow spegel mirroring of latest tag

Types of Changes

version bump
enhancement

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Bump spegel to v0.0.18-k3s3
Adds wildcard registry support
Fixes issue with excessive CPU utilization while waiting for containerd to start
Add env var to allow spegel mirroring of latest tag

Further Comments

dereknola
dereknola previously approved these changes Feb 29, 2024
vitorsavian
vitorsavian previously approved these changes Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 42.81%. Comparing base (513c341) to head (9c8b07a).

❗ Current head 9c8b07a differs from pull request most recent head dc6ddba. Consider uploading reports for the commit dc6ddba to get more accurate results

Files Patch % Lines
pkg/spegel/spegel.go 0.00% 19 Missing ⚠️
pkg/spegel/bootstrap.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9599      +/-   ##
==========================================
- Coverage   45.88%   42.81%   -3.07%     
==========================================
  Files         151      154       +3     
  Lines       13509    13534      +25     
==========================================
- Hits         6198     5795     -403     
- Misses       6080     6570     +490     
+ Partials     1231     1169      -62     
Flag Coverage Δ
e2etests ?
inttests 39.38% <0.00%> (?)
unittests 15.94% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dereknola
dereknola previously approved these changes Mar 1, 2024
vitorsavian
vitorsavian previously approved these changes Mar 1, 2024
@brandond brandond dismissed stale reviews from vitorsavian and dereknola via 59f98a2 March 1, 2024 21:34
galal-hussein
galal-hussein previously approved these changes Mar 1, 2024
@brandond brandond merged commit 091a5c8 into k3s-io:master Mar 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants