[release-1.28] Backports for 2024-03 release cycle

[brandond]

Proposed Changes

Backport:

• fix: use correct wasm shims names #9519
• Use and version flannel/cni-plugin properly #9635
• Bump spegel #9599
• Tweak netpol node wait logs #9581
• Fix coredns NodeHosts on dual-stack clusters #9584
• Bump helm-controller/klipper-helm versions #9595
• Fix snapshot prune #9502
• Fix issue with etcd node name missing hostname #9522
• Rootless mode also bind service nodePort to host for LoadBalancer type #9512
• Disable color outputs using NO_COLOR env var #9357
• Fix additional corner cases in registries handling #9556
• Fix wildcard with embbeded registry test #9649
• Bump metrics-server to v0.7.0 #9673
• Warn and suppress duplicate registry mirror endpoints #9697

Types of Changes

backports

Verification

See linked issues

Testing

Linked Issues

• [Release-1.28] - Panic when etcd-snapshot-dir does not exist #9389
• [Release-1.28] - Fix remaining corner cases in containerd certs.d support #9637
• [Release-1.28] - Add option to disable colors in check-config output. #9667
• [Release-1.28] - klipper-helm: Reinstalling job of a failed chart fails. (PR linked) #9622
• [Release-1.28] - Bind LoadBalancer nodePort for rootless k3s #9613
• [Release-1.28] - k3s-server creates improper etcd member name #9611
• [Release-1.28] - etcd-snapshot prune does not load retention policy from config #9639
• [Release-1.28] - Bump helm CLI in klipper-helm #9620
• [Release-1.28] - Core DNS NodeHosts partially breaks resolving of node's addresses in dualstack configuration. #9616
• [Release-1.28] - Fix Error getting the node object error spew on initial startup #9618
• [Release-1.28] - Provide a means to specify that docker images from any registry should be retrieved from a given registry or the embedded registry #9664
• [Release-1.28] - Add ability to enable "latest" image tag support for Spegel registry. #9662
• [Release-1.28] - Drop flannel/cni-plugin from our fork of containernetworking/plugins #9657
• [Release-1.28] - K3s uses incorrect wasm shims names #9651
• [Release-1.28] - Bump metrics-server to v0.7.0 #9674
• [Release-1.28] - Duplicate mirror endpoint causes containerd to fail to load mirror config from hosts.toml #9694

User-Facing Change

fix: use correct wasm shims names
The embedded flannel cni-plugin binary is now built and versioned separate from the rest of the cni plugins and the embedded flannel controller.
Bump spegel to v0.0.18-k3s3
Adds wildcard registry support
Fixes issue with excessive CPU utilization while waiting for containerd to start
Add env var to allow spegel mirroring of latest tag
Tweak netpol node wait logs
Fix coredns NodeHosts on dual-stack clusters
Bump helm-controller/klipper-helm versions
Fix snapshot prune
Fix issue with etcd node name missing hostname
Rootless mode should also bind service nodePort to host for LoadBalancer type, matching UX of rootful mode.
To enable raw output for the `check-config` subcommand, you may now set NO_COLOR=1
Fix additional corner cases in registries handling
Bump metrics-server to v0.7.0
K3s will now warn and suppress duplicate entries in the mirror endpoint list for a registry. Containerd does not support listing the same endpoint multiple times as a mirror for a single upstream registry.

Further Comments

[codecov]

Codecov Report

Attention: Patch coverage is 56.83761% with 101 lines in your changes are missing coverage. Please review.

Project coverage is 41.04%. Comparing base (0726758) to head (ab630df).

Files	Patch %	Lines
pkg/node/controller.go	58.73%	14 Missing and 12 partials ⚠️
pkg/spegel/spegel.go	0.00%	24 Missing ⚠️
pkg/agent/containerd/config.go	82.75%	9 Missing and 6 partials ⚠️
pkg/etcd/snapshot.go	36.36%	11 Missing and 3 partials ⚠️
pkg/rootlessports/controller.go	0.00%	6 Missing ⚠️
pkg/spegel/bootstrap.go	0.00%	5 Missing ⚠️
pkg/agent/run.go	50.00%	3 Missing and 1 partial ⚠️
pkg/etcd/etcd.go	0.00%	3 Missing and 1 partial ⚠️
pkg/agent/netpol/netpol.go	0.00%	3 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           release-1.28    #9669      +/-   ##
================================================
- Coverage         42.72%   41.04%   -1.69%     
================================================
  Files               154      154              
  Lines             15769    16785    +1016     
================================================
+ Hits               6738     6889     +151     
- Misses             7851     8728     +877     
+ Partials           1180     1168      -12     

Flag	Coverage Δ
e2etests	?
inttests	37.32% <25.64%> (?)
unittests	15.48% <49.69%> (+0.23%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[VestigeJ]

LGTM