Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitco… #890

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitco… #890

merged 1 commit into from
Apr 5, 2024

Conversation

brianphaley
Copy link

…de (#744)

  • Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitcode

  • Address test_check_restart_timestamps issues in py3.10

  • apply appropriate mocks during test_service unit tests

(cherry picked from commit 0f7ca53)

@addyess @brianphaley
Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitco…
95a9ddd 
…de (juju#744)

* Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitcode

* Address `test_check_restart_timestamps` issues in py3.10

* apply appropriate mocks during test_service unit tests

(cherry picked from commit 0f7ca53)
fnordahl
fnordahl approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@fnordahl fnordahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fnordahl fnordahl merged commit 9826d02 into juju:stable/zed Apr 5, 2024
4 checks passed
@fnordahl fnordahl mentioned this pull request Apr 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnordahl fnordahl fnordahl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianphaley @fnordahl @addyess