Skip service_enable if already enabled #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianphaley
commented
Apr 5, 2024
|
Thank you for putting forward multiple options to solve this, I chose to merge #890 which would allow us to consider this PR in a uniform manner along with the other backports. Would you be able to rebase? |
|
Sure, I can rebase this one. I threw the squashed option because i wanted them both tested together, but github had other plans. The cherry-pick for 890 at least fixed the unit test failure locally. |
Repeatedly calling service_enable for a service that
is already enabled can lead to unintended consequences.
Some charms frequently call servie_resume which will
call service('enable') and this adds a check to only
do so of the service is not enabled.
Related-Bug: #2058505
(cherry picked from commit a334500)
brianphaley
force-pushed
the
skip-service-resume-zed
branch
from
b9720c9
to
9707e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly calling service_enable for a service that is already enabled can lead to unintended consequences. Some charms frequently call servie_resume which will call service('enable') and this adds a check to only do so of the service is not enabled.
Related-Bug: #2058505
(cherry picked from commit a334500)