im: Relax Send + Sync bounds #63
Conversation
… that implements Send if T does.
jplatte
force-pushed
the
jplatte/send-sync
branch
from
7a55800 to
e218ce8
Compare
|
Should |
| @@ -0,0 +1,161 @@ | |||
| // Copy-pasted from https://docs.rs/tokio-util/latest/src/tokio_util/sync/reusable_box.rs.html | |||
There was a problem hiding this comment.
Should we add the license, or create an ATTRIBUTION file?
There was a problem hiding this comment.
Is that some sort of standard? I didn't find anything immediately.
I felt when writing this that the comment at the top should be sufficient attribution for copying a small file out of a permissively-licensed project. I suppose it wouldn't hurt to note the original license. I don't think adding the license anywhere is necessary though, since MIT allows redistributing stuff under a different license IIRC (I am not a lawyer, of course).
Also, I plan to get rid of this module again in the future anyways, once tokio-rs/tokio#6908 is merged and another release is made it should be possible to write a self-referential future by hand that can be stored in the VectorSubscriberStream without going through dyn Future. It's a bit tricky though, and I haven't had any focus time for that sort of stuff lately. Let me know if you're interested in helping out 😉
No, I don't think any other code should be updated. The custom |
|
Not sure when I'll get to implementing this in another way, though I would like to. Probably makes sense to merge this as-is for now (potentially with light adjustments for attribution). |
…nown`. This patch updates `eyeball-im` and `eyeball-im-util` to integrate jplatte/eyeball#63. With this new feature, we can have a single implementation of `ObservableMap` (instead of 2: one for all targets, one for `wasm32-u-u`). It makes it possible to get `Client::rooms_stream` available on all targets now.
…nown`. This patch updates `eyeball-im` and `eyeball-im-util` to integrate jplatte/eyeball#63. With this new feature, we can have a single implementation of `ObservableMap` (instead of 2: one for all targets, one for `wasm32-u-u`). It makes it possible to get `Client::rooms_stream` available on all targets now.
…nown`. This patch updates `eyeball-im` and `eyeball-im-util` to integrate jplatte/eyeball#63. With this new feature, we can have a single implementation of `ObservableMap` (instead of 2: one for all targets, one for `wasm32-u-u`). It makes it possible to get `Client::rooms_stream` available on all targets now.
…nown`. This patch updates `eyeball-im` and `eyeball-im-util` to integrate jplatte/eyeball#63. With this new feature, we can have a single implementation of `ObservableMap` (instead of 2: one for all targets, one for `wasm32-u-u`). It makes it possible to get `Client::rooms_stream` available on all targets now.
No description provided.