feat(base): Make ObservableMap::stream works on wasm32-unknown-unknown
#4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nown`. This patch updates `eyeball-im` and `eyeball-im-util` to integrate jplatte/eyeball#63. With this new feature, we can have a single implementation of `ObservableMap` (instead of 2: one for all targets, one for `wasm32-u-u`). It makes it possible to get `Client::rooms_stream` available on all targets now.
Hywan
force-pushed
the
chore-update-eyeball-im
branch
from
8a693c8 to
e7ac2a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4255 +/- ##
==========================================
+ Coverage 84.90% 84.94% +0.03%
==========================================
Files 274 274
Lines 29761 29752 -9
==========================================
+ Hits 25270 25273 +3
+ Misses 4491 4479 -12 ☔ View full report in Codecov by Sentry. |
|
You didn't upgrade the util crate (latest release is technically breaking, so I bumped the minor version). Seems like it's not necessary for this, but wouldn't hurt either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates
eyeball-imandeyeball-im-utilto integrate jplatte/eyeball#63. With this new feature, we can have a single implementation ofObservableMap(instead of 2: one for all targets, one forwasm32-u-u). It makes it possible to getClient::rooms_streamavailable on all targets now.This was required to get
matrix-sdk-uiusable onwasm32-u-u, esp. theRoomListService.