Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file documentation and project source of log4j2. #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexJava2015
Copy link
Collaborator

File contains changes of new version and environment configuration. The project have basic structure to use file properties and execute classic HelloWorld example.

File contains changes of new version and environment configuration. The project have basic structure to use file properties and execute classic HelloWorld example.
Copy link
Owner

@jorgerdc jorgerdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listo, revisión 1 concluida.
Please, no vayas a eliminar el PR :p
Como lo comenté, este es solo el módulo 1, seguramente habrá modulo 2 cierto ¿?

log4j2/docs/log4j2-tutorial.md Show resolved Hide resolved
* Algunas de las funcionalidades de Log4j2:
* Message API
* Java 8 lambda support
* Mixing {}-style
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Traducir a español. En general, revisar esta lista. Esto parece un copy & paste de la documentación. Traduce todas las funcionalidades al español, y agrega un muy breve descripción.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se realizó la traducción y se agrego la descripción correspondiente.

log4j2/docs/log4j2-tutorial.md Outdated Show resolved Hide resolved
* SLF4J Markers'
## Configuración
### Ecosistema
* Existen diversas herramientas para la administración de proyectos, con tipos de instalación tradicional como: Maven, Gradle, Ivy, etc.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¿cuál es la idea de la primer viñeta en relación con la segunda? Al leerlas genera la impresión que una no tiene que ver con la otra..

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se mueve esta sección a otro módulo

log4j2/docs/log4j2-tutorial.md Outdated Show resolved Hide resolved
@@ -0,0 +1,30 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quedamos en que ibas a eliminar este archivo. ¿ no funciona si lo quitas ?

log4j2/example-log4j2/.project Outdated Show resolved Hide resolved
@@ -0,0 +1,2 @@
connection.project.dir=
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismo caso, Quedamos en que ibas a eliminar este archivo. ¿ no funciona si lo quitas ?

log4j2/example-log4j2/.settings/org.eclipse.jdt.core.prefs Outdated Show resolved Hide resolved
* The above copyright notice and this permission notice shall be
* included in all copies or substantial portions of the Software.
*/
package log4j2;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Emplear una estructura de paquetes similar a la que se usa en el tutorial de JUnit5

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se realizo el ajuste correspondiente.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants