-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file documentation and project source of log4j2. #22
base: master
Are you sure you want to change the base?
Conversation
File contains changes of new version and environment configuration. The project have basic structure to use file properties and execute classic HelloWorld example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Listo, revisión 1 concluida.
Please, no vayas a eliminar el PR :p
Como lo comenté, este es solo el módulo 1, seguramente habrá modulo 2 cierto ¿?
* Algunas de las funcionalidades de Log4j2: | ||
* Message API | ||
* Java 8 lambda support | ||
* Mixing {}-style |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Traducir a español. En general, revisar esta lista. Esto parece un copy & paste de la documentación. Traduce todas las funcionalidades al español, y agrega un muy breve descripción.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Se realizó la traducción y se agrego la descripción correspondiente.
log4j2/docs/log4j2-tutorial.md
Outdated
* SLF4J Markers' | ||
## Configuración | ||
### Ecosistema | ||
* Existen diversas herramientas para la administración de proyectos, con tipos de instalación tradicional como: Maven, Gradle, Ivy, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¿cuál es la idea de la primer viñeta en relación con la segunda? Al leerlas genera la impresión que una no tiene que ver con la otra..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Se mueve esta sección a otro módulo
log4j2/example-log4j2/.classpath
Outdated
@@ -0,0 +1,30 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quedamos en que ibas a eliminar este archivo. ¿ no funciona si lo quitas ?
@@ -0,0 +1,2 @@ | |||
connection.project.dir= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mismo caso, Quedamos en que ibas a eliminar este archivo. ¿ no funciona si lo quitas ?
* The above copyright notice and this permission notice shall be | ||
* included in all copies or substantial portions of the Software. | ||
*/ | ||
package log4j2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emplear una estructura de paquetes similar a la que se usa en el tutorial de JUnit5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Se realizo el ajuste correspondiente.
File contains changes of new version and environment configuration. The project have basic structure to use file properties and execute classic HelloWorld example.